Skip to content
This repository was archived by the owner on Jan 22, 2024. It is now read-only.

Conversation

@mathiasbynens
Copy link
Contributor

Update any mentions of browser support throughout the article. Chromium 32 (i.e. Chrome 32 and Opera 19) supports promises by default.

This patch includes various other tweaks and minor improvements.

Update any mentions of browser support throughout the article. Chromium 32 (i.e. Chrome 32 and Opera 19) supports promises by default.

This patch includes various other tweaks and minor improvements.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry I had to get rid of the joke here :( You can probably work it back in somehow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaffathecake - can you sort this merge.
On 27 Jan 2014 10:05, "Mathias Bynens" [email protected] wrote:

In content/tutorials/es6/promises/en/index.html:

@@ -183,14 +183,13 @@

Promises arrive in JavaScript!

Although they're a JavaScript feature, the DOM isn't afraid to use them. In fact, all new DOM APIs with async success/failure methods will use promises. This is happening already with Quota Management, Font Load Events, ServiceWorker, Web MIDI, Streams, and more.

Browser support & polyfill

-

There are already (partial) implementations of promises in browsers today.

-

When in Chrome, do as the Chromans do. Download Canary, which has promises enabled by default. Alternatively, if you're of the Firefox persuasion, grab their latest nightly, which also features promises.

+

There are already implementations of promises in browsers today.

+

As of Chrome 32 and Opera 19, promises are enabled by default. Alternatively, if you're of the Firefox persuasion, grab their latest nightly, which has partial promises support.

So sorry I had to get rid of the joke here :( You can probably work it
back in somehow.


Reply to this email directly or view it on GitHubhttps://github.com//pull/921/files#r9197279
.

@jakearchibald
Copy link
Contributor

LGTM

jakearchibald added a commit that referenced this pull request Jan 27, 2014
@jakearchibald jakearchibald merged commit 3239c09 into html5rocks:master Jan 27, 2014
@Wuntenn
Copy link

Wuntenn commented Oct 26, 2015

You say halfway down that this the 'first time' that we've come across promise.resolve, however at this point in the article you mentioned it previously.

You showed above how it could be used to cast a jQuery's Deferred to a standard promise.

Copy link

@levelingup levelingup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link doesn't work

</dl>

<p>The spec also uses the term <strong>thenable</strong> to describe an object that is promise-like, in that it has a "then" method. This term reminds me of ex-England Football Manager <a href="http://en.wikipedia.org/wiki/Terry_Venables">Terry Venables</a> so I'll be using it as little as possible.</p>
<p><a href="http://people.mozilla.org/~jorendorff/es6-draft.html#sec-promise-objects">The spec</a> also uses the term <strong>thenable</strong> to describe an object that is promise-like, in that it has a <code>then</code> method. This term reminds me of ex-England Football Manager <a href="http://en.wikipedia.org/wiki/Terry_Venables">Terry Venables</a> so I'll be using it as little as possible.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link no longer works.

Copy link

@t10-13rocket t10-13rocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@t10-13rocket t10-13rocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants