Fix validation-group not working properly #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The validation-group didn't properly set validity of other elements in the group
Collaborator
Author
|
@huei90, will merge after your confirmation. |
src/validator.directive.js
Outdated
| * @param groupName | ||
| * @param validity | ||
| */ | ||
| function setValiationGroup(scope, validationGroup, validity) { |
Collaborator
Author
There was a problem hiding this comment.
That's kind of embarrassing...., fixing
Owner
|
This PR contains many changes but I believe on you 😄 Feel free to merge it. |
Owner
Owner
|
btw, great job 🍻 |
Collaborator
Author
|
I wrote more tests on it. So, it should be reliable enough. 😄 |
lvarayut
force-pushed
the
validation-group
branch
from
99163c8 to
7ca756a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the validation-group problem, the validation-group didn't properly set validity of other elements in a group.
Closes #210