Validation Group and form checkValid

[dapriett]

Hello,

It looks like checkValid for a form returns false unless everything in the validation group is valid. You can see this in your example by only selecting 1 checkbox https://github.com/huei90/angular-validation/blob/master/index.html#L325

Shouldn't the form be valid if at least one is selected?

[hueitan]

Thank you for reporting this issue @dapriett 🍻

[hueitan]

@lvarayut Do you have time to look at this?

[lvarayut]

I'll take a look at it as soon as possible, probably at the end of next week. Before that, if anybody could get it done, that would be really welcomed.

[dapriett]

Thank you! Any plans to push a new release - looks like 1.4.1 is still the latest.

[lvarayut]

@huei90, I think that it's better to get the #212 done before releasing a new version.

[hueitan]

agree.

[mooyoul]

It seems broken again 😢

I just tested on Form ($submit-only) section on example page.

It seems validation passed okay when checks any checkbox, but checkValid remains false even i entered ALL of input items. there are no invalid messages, or indicators. it won't trigger ng-click handler with validation-submit directive combo too.

I'm guessing the root cause of this issue was from NgModelController of unchecked checkboxes.
$valid property of NgModelController were set to false even there are validation-group directive exists.
this makes parent FormController.$valid to false.