valid-callback & invalid-callback not working on angular-validation 1.4

[knulan]

After update to latest angular 1.4 (1.4.9) from 1.3.x , valid-callback & invalid-callback functions stop working

[hueitan]

The test shows it correctly
https://github.com/huei90/angular-validation/blob/master/test/unit/callbackSpec.js

Also the demo page with invalid-callback works.

[duyongxin]

invalid-callback & valid-callback not work as they are provided by attribute

<label>Required (Invalid Callback alert)</label> <input type="text" name="requiredCallback" ng-model="form.requiredCallback" validator="required" invalid-callback='error("Must be Required");'/>

[hueitan]

@knulan @duyongxin Thanks for your report, I have found the error one, the valid/invalid-callback in attrs doesn't trigger.

[hueitan]

Looks like the default valid/invalid-callback is missing start from one version, need more time to fix it.

[knulan]

@huei90 any progress on this?

[hueitan]

unfortunately no =( I'm busy on other things right now. see if someone can help on fixing.

[dmitry-dedukhin]

Seems that this commit is a root cause of the problem

[hueitan]

changing it back to scope.validCallback & scope.invalidCallback should work 😄

[dmitry-dedukhin]

No, there is no isolated scope any more.
So, the fix should be like the following:

- var invalidCallback = $parse('error');
+ var invalidCallback = $parse(attrs.invalidCallback);
...
- if (invalidCallback) invalidCallback({
-   message: messageToShow
- });
+ invalidCallback(scope, {
+   message: messageToShow
+ });

And the same changes should be done in validFunc.

[hueitan]

Thank you @dmitry-dedukhin You are right 🍻

Do you mind creating a pull request to fix this?

[dmitry-dedukhin]

Done, #206