Skip to content

Conversation

@hueitan
Copy link
Owner

@hueitan hueitan commented Dec 29, 2015

This should be correct @lvarayut

we will see the coveralls result until merge into master.

Local Result Screenshot:

screen shot 2015-12-29 at 4 26 20 pm

Gruntfile.js Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this option you can run coverage without sending data to the coveralls service and instead writing the results to coveralls.json.

Should it be false? because we need to send data to coveralls service.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps.. change it to false

@lvarayut
Copy link
Collaborator

It looks good to me. I'll merge it when the travis finished.

@hueitan
Copy link
Owner Author

hueitan commented Dec 29, 2015

Cool, here's the result from coveralls.
https://coveralls.io/github/huei90/angular-validation

lvarayut added a commit that referenced this pull request Dec 29, 2015
@lvarayut lvarayut merged commit e37495f into master Dec 29, 2015
@hueitan
Copy link
Owner Author

hueitan commented Dec 29, 2015

🚀

@hueitan hueitan deleted the coveralls branch December 29, 2015 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants