fix(tracing): revert #134 - tracing span removal in legacy DNS GaiResolver
#179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The impact of reverting this is that DNS requests will no longer be under the same span that tracks the request. This may affect tracing and metrics on any places where this info is tracked. That said, this downside is less problematic than the alternative which causes panics, so I'm for this being merged |
joshka
approved these changes
Apr 2, 2025
Contributor
|
Captured the overall details of the span in DNS problem in hyperium/hyper#3870 |
seanmonstar
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracinghas an unresolved bug when attempting to fetch a span that should exist. Tracking: tokio-rs/tracing#3223 (comment)#134 introduces this bug.
hypercontributors aren't at fault — this is atracingissue.As a result, crates that depend on
hyper's legacy client (e.g.reqwest) will immediately panic when a request is sent under specific circumstances configured bytracingspans. (The tracked comment shows a pseudocode example). This slightly more accuratetracingspan is not worth the panics.In theory, this PR can be reverted once
tracingresolves this issue, but its up to the maintainers whether or not it should be prioritized.