feat(client): add proxy::SocksV4 and proxy::SocksV5 connectors #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think this looks pretty great! What's holding it back as a draft? |
Contributor
Author
|
Needed to test optimistic sending to see if it was worth including. 5/8 of the server implementations I tested worked so I feel like it's a worthwhile addition even if it's not in the RFC. Will fix the failing check and some of the dirty code in a little, but I'm mostly happy with everything now |
seanmonstar
approved these changes
May 19, 2025
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
This looks phenomenal, thank you!
Contributor
Author
|
Thanks for merging this. Is the goal still to refactor Reqwest to use these connectors? I'm happy to take that on to pad my stats so to speak ;) |
Member
|
Yes it is, just filed a new issue: seanmonstar/reqwest#2683 I've got the HTTP tunnel one nearly done, but I haven't started on the SOCKS, if you want to try that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc hyperium/hyper#3851, hyperium/hyper#3877 #173
Adds
SocksV4andSocksV5connectors with simple configuration for local and remote DNS. Supports SOCKSv5 user/pass authentication and allows optimistic message sending (not in RFC but supported by most servers) to reduce number of round-trips in SOCKSv5 handshake.TODO: