Skip to content

Conversation

@icelam
Copy link
Owner

@icelam icelam commented Aug 4, 2022

Description

Fixing issue #387 where any "</script>" string that appears inside source breaks webpage if not escaped.

How has this been tested?

  1. Created a minimum webpack config and sources which contains more than 1 "</script>" string, located at __tests__/cases/escape-script-end-tag
    a. this is tested by running webpack in Jest
    b. Open the build files produced after running webpack in browser, check and make sure there is no script error

Types of changes

  • New feature - feat
  • Bug fix - fix
  • Refactor - refactor
  • Test cases - test
  • Other(s):

Remarks

N/A

@icelam icelam marked this pull request as ready for review August 5, 2022 03:49
@icelam icelam merged commit 019a41d into develop Aug 5, 2022
@icelam icelam deleted the escape-script-end-tag branch August 5, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants