Fix session reuse in repository search count query #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pedrogaudencio
commented
Nov 3, 2025
pedrogaudencio
commented
- Refactor searchRepositoryByCondition to reuse the same database session for both count and main queries, instead of creating a new session via db.GetEngine(ctx) for the count.
- The count query is now performed before adding JOINs to the session, since JOINs are only needed for ordering by subject fields, not for counting repositories.
* Refactor searchRepositoryByCondition to reuse the same database session for both count and main queries, instead of creating a new session via db.GetEngine(ctx) for the count. * The count query is now performed before adding JOINs to the session, since JOINs are only needed for ordering by subject fields, not for counting repositories. Fixes okTurtles/forkana/issues/27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
