Bundled pretty-printer for LLDB: Rc, Arc support #3024
Conversation
artemmukhin
force-pushed
the
debugger-rc-arc
branch
3 times, most recently
from
dd5bc92 to
28294a4
Compare
prettyPrinters/providers.py
Outdated
| if index == 1: | ||
| count = self.weak.GetValueAsSigned() | ||
| data = SBData.CreateDataFromUInt64Array(self.endianness, self.pointer_size, [count]) | ||
| return self.valobj.CreateValueFromData("weak", data, self.count_type) |
There was a problem hiding this comment.
It seems we should move code about usize to SBValue conversion into a separate function because we already have two similar pieces of code in this PR. Also, there is another one in #3037
There was a problem hiding this comment.
Probably, it should be a method of some new class because we also need to store process properties too (endianness and pointer_size)
There was a problem hiding this comment.
Good idea! I've created ValueBuilder for such needs.
prettyPrinters/providers.py
Outdated
| # type: (str) -> int | ||
| if name == "strong": | ||
| return 0 | ||
| if name == "weak": |
There was a problem hiding this comment.
Do we need strong and weak children at all? For example, formatter for C++ shared_ptr doesn't provide such children, only add them into summary
There was a problem hiding this comment.
Yes, C++ pretty-printer uses the interesting trick:
def num_children(self):
return 1
def get_child_at_index(self, index):
if index == 0: ...
if index == 1: ...
if index == 2: ...
So the synthtetic provider doesn't show the 1st and 2nd children, but summary provider can access (and show) these.
I will use it too.
artemmukhin
force-pushed
the
debugger-rc-arc
branch
4 times, most recently
from
b2e5364 to
8f12ae2
Compare
artemmukhin
force-pushed
the
debugger-rc-arc
branch
from
8f12ae2 to
ce718d5
Compare
|
bors r+ |
3024: Bundled pretty-printer for LLDB: Rc, Arc support r=Undin a=ortem This PR adds `Rc` and `Arc` support to LLDB pretty-printers. <img width="374" alt="rc1" src="https://user-images.githubusercontent.com/4854600/48424354-86958000-e773-11e8-971d-e0fdeeb2eadb.png"> <img width="334" alt="rc2" src="https://user-images.githubusercontent.com/4854600/48424355-86958000-e773-11e8-9d02-233e00ff62fb.png"> Merge after #3017. Co-authored-by: ortem <[email protected]>
2 participants
This PR adds
RcandArcsupport to LLDB pretty-printers.Merge after #3017.