Support for JDK 1.8.0

[szegedi]

Status Overview

Latest snapshot build: Snapshot Repository

[x] ASM5: Release Required

We need a new ASM version which supports class file version 52.0. ASM 5.0_BETA is released to Maven central repo.

• ASM Bug 316481 (fixed)

[x] Adjust JaCoCo to new ASM APIs: Done

JaCoCo needs to be adjusted to ASM5 APIs. This has been done on a experimental branch.

[x] Select proper runtime implementation: Done

The ModifiedSystemClassRuntime does not work any more with JRE 8. So an alternative Runtime has to be selected. The UrlStreamHandlerRuntime seems to do the job.

[x] Maven JavaDoc: Workaround

With JDK 8 JavaDoc generated by Maven fails to compile due to Lint checks. As a workaround we can disable this check for the Maven plugin.

• JaCoCo Build Fails with Java 8 due to invalid JavaDoc in HelpMojo #83
• Maven Plugin Tools Bug 244

[x] Invalid Line Numbers: Fixed with JDK Build 103

The JDK 8 compiler missed line number information in certain cases which makes our integration tests fail (and also leads to wrong line coverage results).

• Bug JDK-8020689

[marchof]

Java 8 is not yet supported by ASM, see feature request http://forge.ow2.org/tracker/index.php?func=detail&aid=316375&group_id=23&atid=350023

The other problem is that ModifiedSystemClassRuntime() is not working any more.

[karianna]

I might be mistaken, but IIRC ASM is now included as part of Java 8 (since Nashorn went in).

[marchof]

@karianna Do you have any background information or links? Is it public API and compatible with ASM 4.1?

[szegedi]

Well, ASM is embedded as a package-renamed "jdk.internal.org.objectweb.asm" version. It's not really useful to rely on its presence like that. It was actually not Nashorn that triggered the embedding - JDK8 has other needs for runtime code generators (e.g. lambda forms).

FWIW, it's irrelevant; what we need is ASM that recognizes the 52.0 as a valid class file version, but unfortunately that alone won't be enough to make JaCoCo work with a Java 8 runtime :-(

[karianna]

+1 on what +szegedi said (he's at the forefront of all of this)

[marchof]

Some testing with ASM 5-alpha. It turned out that they changed the way how implicit stackmap frames are handled. JaCoCo needs to be adjusted to the new behaviour:

http://forge.ow2.org/tracker/?group_id=23&atid=100023&func=detail&aid=316360

[marchof]

The issue above has been just fixed in ASM 5:

http://forge.ow2.org/tracker/?func=detail&atid=100023&aid=316481&group_id=23

[marchof]

Compiler issue with line numbers has been reported to Oracle, bug number is 9005197 (http://bugs.sun.com) -- not yet acknowledged.

[marchof]

My current Java 8 experiments are now available in branch experimental-java8. There is also a first preview build.

Warning: This build depends on a not yet released version of ASM. Therefore all Maven goals will not yet work unless you build ASM on your own and publish it in a local repo. The JaCoCo agent and the Ant tasks should be usable though.

[karianna]

Hi Marc,

We're tracking this as part of Adopt OpenJDK -
https://java.net/projects/adoptopenjdk/pages/TestingJava8 - thanks for
looking into this!

Cheers,
Martijn

On 18 July 2013 20:12, Marc R. Hoffmann notifications@github.com wrote:

My current Java 8 experiments are now available in branch
experimental-java8https://github.com/jacoco/jacoco/tree/experimental-java8.
There is also a first preview buildhttp://download.eclipselab.org/jacoco/preview/jacoco-0.6.4.201307180853.zip
.

Warning: This build depends on a not yet released version of ASM.
Therefore all Maven goals will not yet work unless you build ASM on your
own and publish it in a local repo. The JaCoCo agent and the Ant tasks
should be usable though.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-21207105
.

[marchof]

Thanks Martijn! We also have an issue with JDK8 itself but I didn't manage to report issue. My email to compiler-dev didn't get published on the list, my bug report 9005197 hasn't been acknowledged :-(

[karianna]

Can you send me the details? I can post on your behalf.

Cheers,
Martijn

On 18 July 2013 22:01, Marc R. Hoffmann notifications@github.com wrote:

Thanks Martijn! We also have an issue with JDK8 itself but I didn't manage
to report issue. My email to compiler-dev didn't get published on the list,
my bug report 9005197 hasn't been acknowledged :-(

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-21214633
.

[marchof]

Bugreport for JDK8 compiler: https://gist.github.com/marchof/6036631

[karianna]

Thanks Marc, that's a really great report - I've passed it onto the compiler dev team and am also chasing down why the bug is not public. Will keep you posted!

[karianna]

See http://bugs.sun.com/view_bug.do?bug_id=8020689