Skip to content

Susy201010 #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaquinelio merged 22 commits into from
Oct 20, 2020
Merged

Susy201010 #415

joaquinelio merged 22 commits into from
Oct 20, 2020

Conversation

@joaquinelio
Copy link
Member

@joaquinelio joaquinelio commented Oct 10, 2020

debio ser 20 10 09...

haond10adp and others added 19 commits September 26, 2020 09:16
@haond10adp
minor change
5189d51
@haond10adp
Update article.md
02e82ad
@Mr0cket
Update 'properties' to 'property values'
73550e5 
The task asks to multiply numeric object 'properties', however the term 'object properties' include both the 'property keys' of the object as well as the 'property values' of the object. It is clear the intention of the task is to change property values. 
This change improves clarity of the task description.
@ZYinMD
correct minor typo
2c65914
@Ledorub
Fix wrong variables names.
af95ad1
@vsemozhetbyt
Fix link in 1.2.18
c970f42 
The current link is redirected to the parent chapter.
This fix is in sync with
https://javascript.info/operators#bitwise-operators and #2117
@CrypterSr
Update README.md
f11dd6d
@Anurag-Chauhan-289
Update README.md
af9b339
@Anurag-Chauhan-289
Update article.md
1d13d11
@iliakan
Merge pull request #2151 from haond10adp/patch-1
6f24128 
minor change
@iliakan
Merge pull request #2155 from Mr0cket/patch-2
1200946 
1.4.1.8_multiply numeric - Update 'properties' to 'property values'
@iliakan
Merge pull request #2157 from ZYinMD/patch-3
77e2dee 
correct minor typo
@iliakan
Merge pull request #2158 from Ledorub/indexeddb-example-fix
d77dbf8 
Fix wrong variables names.
@iliakan
Merge pull request #2159 from vsemozhetbyt/patch-2
fa0bcd3 
Fix link in 1.2.18
@iliakan
Merge pull request #2162 from CrypterSr/patch-1
ea8fc1a 
Update README.md
@iliakan
Merge pull request #2163 from Anurag-Chauhan-289/master
6c6a7b5 
improved doc
@paroche
Update article.md
bdb3def 
As promised.
@iliakan
minor fixes
edef0b4
@joaquinelio
Merge enstream/master into susy201010
10390aa
@javascript-translate-bot javascript-translate-bot requested a review from a team October 10, 2020 01:37
@CLAassistant
Copy link

CLAassistant commented Oct 10, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 10 committers have signed the CLA.

✅ vsemozhetbyt
✅ iliakan
✅ joaquinelio
❌ Mr0cket
❌ ZYinMD
❌ haond10adp
❌ Ledorub
❌ Anurag-Chauhan-289
❌ CrypterSr
❌ paroche
You have signed the CLA already but the status is still pending? Let us recheck it.

vplentinax
vplentinax requested changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primera revisión rápida. Luego vuelvo.

@javascript-translate-bot
Copy link

javascript-translate-bot commented Oct 12, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio
Copy link
Member Author

joaquinelio commented Oct 12, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team October 12, 2020 20:45
vplentinax
vplentinax approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo bien, pequeñas cosas. Puede hacer merge después

@joaquinelio
Copy link
Member Author

joaquinelio commented Oct 19, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team October 19, 2020 17:08
@joaquinelio
Copy link
Member Author

joaquinelio commented Oct 19, 2020

/done pero te tomo la palabra, no lo dejaré abandonado

@joaquinelio joaquinelio merged commit cee00e6 into javascript-tutorial:master Oct 20, 2020
@joaquinelio joaquinelio deleted the susy201010 branch October 20, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplentinax vplentinax vplentinax approved these changes

Assignees

No one assigned

Labels

needs +1 review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.