Skip to content

1.4.7 opt chaining update from ENG #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaquinelio merged 2 commits into from
Oct 21, 2020
Merged

1.4.7 opt chaining update from ENG #419

joaquinelio merged 2 commits into from
Oct 21, 2020

Conversation

@joaquinelio
Copy link
Member

@joaquinelio joaquinelio commented Oct 11, 2020

https://es.javascript.info/optional-chaining

habia un err no visible de formato en ejemplo antes del resumen

@javascript-translate-bot javascript-translate-bot requested a review from a team October 11, 2020 07:52
vplentinax
vplentinax requested changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pequeñas cositas

@javascript-translate-bot
Copy link

javascript-translate-bot commented Oct 14, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio
Copy link
Member Author

joaquinelio commented Oct 15, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team October 15, 2020 02:38
@joaquinelio
Copy link
Member Author

joaquinelio commented Oct 15, 2020 •
edited
Loading

Es mayor responsabilidad del traductor hacer cambios español a español, en review no comparas con el inglés original.

No veo como mejorarlo.
La manera perfecta de review sería bajando el branch y compararlo con lens, pero es una locura no puedo pedir eso para cada modificación.

Más convencido cada vez, la sync delega,
que el artículo se haga sin apuro.
Y la review, con la profundidad que considere el reviewer sin la presion del tiempo/conflictos.

vplentinax
vplentinax approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@joaquinelio joaquinelio merged commit 763cc97 into javascript-tutorial:master Oct 21, 2020
@joaquinelio joaquinelio deleted the chino branch October 21, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplentinax vplentinax vplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquinelio @javascript-translate-bot @vplentinax