-
Notifications
You must be signed in to change notification settings - Fork 104
Sync with upstream @ ec21af8a #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Grammar suggestions
Grammar suggestions
Grammar suggestions
Some of string outputs are represented with quotes but some of not, there is a inconsistency.
splice method's minimum parameter is 'start' and it is number type. In this tutorial 'str' stands for string parameters.
Update article.md
Update article.md
string outputs without quotes
Update article.md
'str' inside of 'start'
For consistency with definition of "arr.filter(fn)" , we need to add 'fn' parameter to definition of arr.find().
Adding missed semicolon in function expression example.
arr.values() is supported by majority of browsers. So, maybe we need to change the exception in article. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/values
':' character is indicating 'var2' is a key of object.
Removed extra "and" in a sentence
Grammar suggestions
Grammar suggestions
variable user is using for both string and object type different values. these situation is called "ninja code" bu author :) "Add a new variable only when absolutely necessary. Instead, reuse existing names. Just write new values into them." https://javascript.info/ninja-code
We need to put 'null' to end of linked list. otherwise wen we want to get last item in the linked list, it will be undefined. And this situation inconsistent with object literal definition of linked list above.
Update article.md
removes russian text chunk from english text
Removed extra "and" in a sentence
correction for code template consistency
function() { return count++; } is running because it is a function declaration. It is running and result of this running a function has been created and sent as a parameter to return command. "return count++;" this part is not running because the function has not been called yet.
Fix syntax error
Update task.md
Update article.md
Update article.md
code non-compatible with clarification drawing
code non-compatible with clarification drawing
arrow function instead of function
Update article.md
Update article.md
"helper function" term reminds "utility libraries" but "wrapper" term refers "function decorators" and in this context wrapper can be more self-descriptive and meaningful.
wrapper instead of helper
bug fix on the server
|
|
This PR was automatically generated to merge changes from en.javascript.info at ec21af8
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterThis PR will be closed and replaced with a new one in a few days.