domvm v3.3.2 #396
Merged
domvm v3.3.2 #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks. Perf results look like that:
|
Contributor
Author
|
these numbers make sense. the impl is much clearer, so i'm happy about that. in the future i'll see if there's any room to get some of the perf back from internal improvements. thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @krausest,
sorry for the rapid update, but this will be the last one for a while.
i simplified the benchmark implementation, removing a couple micro-optimizations (event delegation, jumbotron redraw skipping). the new impl is also less monolithic and more functional/componentized. v3.3.2 also reworks some event listener internals to use addEventListener rather than binding directly to the dom nodes. also, this PR drops a few old/unused devDependencies, so a bit faster builds :)
in my tests, the perf was within +/-2% and +0.2M in the memory metrics. well worth the clearer code, imo.
thanks!