[TTI] Assert that TargetIRAnalyis is not requested for intrinsics #129600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
llvmbot
added
the
llvm:analysis
Member
|
@llvm/pr-subscribers-llvm-analysis Author: Alexander Richardson (arichardson) ChangesThis catches the bug fixed in #127760 Full diff: https://github.com/llvm/llvm-project/pull/129600.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/TargetTransformInfo.cpp b/llvm/lib/Analysis/TargetTransformInfo.cpp
index 1c54395909f10..067b3ec10fc7a 100644
--- a/llvm/lib/Analysis/TargetTransformInfo.cpp
+++ b/llvm/lib/Analysis/TargetTransformInfo.cpp
@@ -1476,6 +1476,7 @@ TargetIRAnalysis::TargetIRAnalysis(
TargetIRAnalysis::Result TargetIRAnalysis::run(const Function &F,
FunctionAnalysisManager &) {
+ assert(!F.isIntrinsic() && "Should not request TTI for intrinsics");
return TTICallback(F);
}
|
Member
Author
|
Depends on #129599 |
arichardson
changed the title
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
arichardson
requested review from
a team,
Groverkss,
JDevlieghere,
Superty,
dcaballe,
nicolasvasilache and
rengolin
as code owners
arichardson
changed the base branch from
users/arichardson/spr/main.tti-assert-that-this-is-not-requested-for-intrinsic-functions
to
main
arichardson
deleted the
users/arichardson/spr/tti-assert-that-this-is-not-requested-for-intrinsic-functions
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 4, 2025
…support When looping over all functions in a module to determine whether any of them is built with support for B.W, we can skip declarations since those do not have an associated target-feature attribute. This was found by the assertion from llvm/llvm-project#129600 Reviewed By: statham-arm Pull Request: llvm/llvm-project#129599
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 4, 2025
…rinsics This catches the bug fixed in llvm/llvm-project#127760 and also finds another call in LowerTypeTests where we request the TTI for instrinsics instead of skipping them. Reviewed By: nikic Pull Request: llvm/llvm-project#129600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches the bug fixed in #127760
and also finds another call in LowerTypeTests where we request the TTI
for instrinsics instead of skipping them.