[BOLT] Drop BOLT_CLANG_EXE #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaskRay
approved these changes
Apr 26, 2024
Member
MaskRay
left a comment
MaskRay
left a comment
There was a problem hiding this comment.
Thanks!
I guess build bots use ninja all. If adding clang builds too many executables, perhaps explicit ninja clang will help.
Contributor
Author
No, BOLT buildbots are configured to only run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to the issue unearthed by
llvm/llvm-project#89693, remove all uses of
BOLT_CLANG_EXE to prevent similar blockers in the future and reduce builder
maintenance overhead.