-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Open
Labels
Breaking ChangeWould introduce errors in existing codeWould introduce errors in existing codeHelp WantedYou can do thisYou can do thisInfrastructureIssue relates to TypeScript team infrastructureIssue relates to TypeScript team infrastructure
Milestone
Description
The --strictNullChecks PR changed some declarations in types.ts to avoid frequent assertions in the compiler's code. Unfortunately these changes make it really unsafe for API users because they no longer contain the actually nullable types: #22088 (comment) #22088 (comment)
ts.Node#parentis no longer optional (which is definitely wrong forSourceFile)ts.Symbol#declarationsandts.Symbol.valueDeclarationare no longer optional, but can still be undefinedts.Type#symbolis no longer optional, but I guess this comment is still up to date:// Symbol associated with type (if any)
These changes should either be reverted or replaced in the published declaration files.
/cc @Andy-MS @weswigham
SlurpTheo, bradzacher, dsherret, ToddThomson, GitTom and 7 more
Metadata
Metadata
Assignees
Labels
Breaking ChangeWould introduce errors in existing codeWould introduce errors in existing codeHelp WantedYou can do thisYou can do thisInfrastructureIssue relates to TypeScript team infrastructureIssue relates to TypeScript team infrastructure