Collect _all_ symlinks a file may have witnessed when attempting to generate specifiers #31571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerate specifiers
andrewbranch
approved these changes
May 23, 2019
|
This doesn't fix the repro I've provided. |
|
@weswigham should I open a new issue as this hasn't fixed my repro? |
|
@weswigham I still encounter the issue as well! |
|
This really hasn't fixed the #29221 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue brought up by @simonfox in this comment.
Also fixes this comment
Fixes #29221, probably - the repro from the OP has had a bit of bitrot and doesn't really compile clean.
The issue was essentially that
importHelperssynthesizes animportentry in every file, which in turn makes a newmoduleResolution- and we were then only inspecting the firstmoduleResolutionfor possible symlinks, rather than all of them (so thetslibimport would prevent us from finding any symlinks).