Retain undefined initializations #36806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
approved these changes
Feb 14, 2020
weswigham
force-pushed
the
retain-undefined-initializations
branch
from
92aeea3 to
6f693aa
Compare
weswigham
added a commit
that referenced
this pull request
Feb 25, 2020
rbuckton
suggested changes
Feb 25, 2020
Contributor
rbuckton
left a comment
rbuckton
left a comment
There was a problem hiding this comment.
Just in case, undefined isn't valid in ES3.
rbuckton
suggested changes
Feb 25, 2020
Contributor
rbuckton
left a comment
rbuckton
left a comment
There was a problem hiding this comment.
This is adding an unnecessary exports.x = undefined for downlevel enums and modules, which includes the comments.
rbuckton
reviewed
Feb 26, 2020
rbuckton
approved these changes
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #35967 based on this comment that causes us to still produce an assignment for exports without initializers, this way they can still be found by importers and have getters made for them. (92aeea3 is the unique commit in this PR)