Skip to content

feat(33792): Add quick fix for `This condition will always return true since the function is always defined. Did you mean to call it instead #37152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amcasey merged 2 commits into from
Mar 13, 2020
Merged

feat(33792): Add quick fix for `This condition will always return true since the function is always defined. Did you mean to call it instead #37152

amcasey merged 2 commits into from
Mar 13, 2020

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Mar 2, 2020 •
edited
Loading

Fixes #33792

@j-oliveras
Copy link
Contributor

j-oliveras commented Mar 2, 2020

Fixes #37149?

@sandersn sandersn added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 12, 2020
amcasey
amcasey suggested changes Mar 12, 2020
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't wait to have this code fix, but I do have one concern.

@a-tarasyuk a-tarasyuk requested review from amcasey and rbuckton March 13, 2020 09:06
amcasey
amcasey approved these changes Mar 13, 2020
View reviewed changes
@amcasey
Copy link
Member

amcasey commented Mar 13, 2020

@rbuckton @andrewbranch Last call for comments

@orta
Copy link
Contributor

orta commented Mar 13, 2020

Good work on the tests 👍

@amcasey amcasey merged commit fc30095 into microsoft:master Mar 13, 2020
@RyanCavanaugh RyanCavanaugh mentioned this pull request Apr 24, 2020
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

+1 more reviewer

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amcasey amcasey

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add quick fix for This condition will always return true since the function is always defined. Did you mean to call it instead

7 participants

@a-tarasyuk @j-oliveras @amcasey @orta @andrewbranch @rbuckton @sandersn