fix(40632): Don't emit abstract members #40699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
nitish-awasthi
approved these changes
Sep 22, 2020
Member
|
We need to push this to 4.2 since it's a fairly observable runtime breaking change |
5 tasks
sandersn
approved these changes
Nov 4, 2020
alangpierce
added a commit
to alangpierce/sucrase
that referenced
this pull request
Aug 2, 2022
Fixes #731 `disableESTransforms` is intended to match the more spec-compliant mode `useDefineForClassFields` provided by TypeScript, but it looks like in TS 4.2 they updated the behavior so that `abstract` fields are removed in addition to `declare` fields: microsoft/TypeScript#40699 In Sucrase, we can implement the same behavior by simply testing for `abstract` as well in the place where we test for `declare`.
alangpierce
added a commit
to alangpierce/sucrase
that referenced
this pull request
Aug 2, 2022
Fixes #731 `disableESTransforms` is intended to match the more spec-compliant mode `useDefineForClassFields` provided by TypeScript, but it looks like in TS 4.2 they updated the behavior so that `abstract` fields are removed in addition to `declare` fields: microsoft/TypeScript#40699 In Sucrase, we can implement the same behavior by simply testing for `abstract` as well in the place where we test for `declare`.
1Lighty
pushed a commit
to Astra-mod/sucrase
that referenced
this pull request
Aug 14, 2022
…ce#732) Fixes alangpierce#731 `disableESTransforms` is intended to match the more spec-compliant mode `useDefineForClassFields` provided by TypeScript, but it looks like in TS 4.2 they updated the behavior so that `abstract` fields are removed in addition to `declare` fields: microsoft/TypeScript#40699 In Sucrase, we can implement the same behavior by simply testing for `abstract` as well in the place where we test for `declare`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40632