Skip to content

Move fixed chunk size polling as a watch option and move it out of server #42542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheetalkamat merged 3 commits into from
Mar 3, 2021
Merged

Move fixed chunk size polling as a watch option and move it out of server #42542

sheetalkamat merged 3 commits into from
Mar 3, 2021

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Jan 28, 2021

Fixes #41549

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 28, 2021

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 28, 2021
@sheetalkamat
Copy link
Member Author

sheetalkamat commented Jan 28, 2021 •
edited
Loading

Because this needs protocol change in tsserver, i am marking this for 4.3 instead.
@mjbvz starting 4.3 there will be one more option for WatchFile, WatchDirectory and fallbackPolling

amcasey
amcasey reviewed Feb 8, 2021
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had trouble following the polling code. Happy to review in person if that's easier.

sheetalkamat
sheetalkamat commented Mar 2, 2021
View reviewed changes
src/compiler/sys.ts
}

polled++;
const fileChanged = onWatchedFileStat(watchedFile, getModifiedTime(host, watchedFile.fileName));
Copy link
Member Author

@sheetalkamat sheetalkamat Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where actual polling happens. and this is the file that gets counted towards the polling. The code was existing just pulled out to helper so that it can be shared.

amcasey
amcasey approved these changes Mar 3, 2021
View reviewed changes
@sheetalkamat sheetalkamat merged commit 0cf834c into master Mar 3, 2021
@sheetalkamat sheetalkamat deleted the watchOptionsTsserver branch March 3, 2021 00:45
@gluxon gluxon mentioned this pull request May 19, 2021
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mjbvz mjbvz Awaiting requested review from mjbvz

@sandersn sandersn Awaiting requested review from sandersn

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

1 more reviewer

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TSServer doesn't respect watchOptions for watchFile

4 participants

@sheetalkamat @typescript-bot @amcasey