Skip to content

Conversation

@sangxxh
Copy link
Contributor

@sangxxh sangxxh commented Feb 11, 2021

Fixes #42741

First contribution.

Update param name and docstring for parseInt to be more readable/consistent.

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 11, 2021
@sangxxh sangxxh changed the title Issue/42741 update parseint type def Update parseInt parameter name and jsdoc Feb 11, 2021
@DanielRosenwasser
Copy link
Member

Looks like the docs affect some tests. Run

gulp runtests
gulp baseline-accept
git add tests
git commit -m "Accepted baselines."
git push

@sangxxh
Copy link
Contributor Author

sangxxh commented Feb 13, 2021

Thanks @DanielRosenwasser

@RyanCavanaugh RyanCavanaugh merged commit 612a96e into microsoft:master Mar 5, 2021
@sangxxh sangxxh deleted the issue/42741-update-parseint-type-def branch March 5, 2021 21:03
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

description of radix argument in parseInt calls string "numString", but parseInt header calls it "s"

4 participants