Skip to content

Retain name and propertyName in declaration emit copies of binding patterns if property name is a keyword #50537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weswigham merged 3 commits into from
Aug 30, 2022
Merged

Retain name and propertyName in declaration emit copies of binding patterns if property name is a keyword #50537

weswigham merged 3 commits into from
Aug 30, 2022
+209 −8

Conversation

@weswigham
Copy link
Member

@weswigham weswigham commented Aug 30, 2022

Fixes #50483

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 30, 2022
jakebailey
jakebailey reviewed Aug 30, 2022
View reviewed changes
@jakebailey
Copy link
Member

jakebailey commented Aug 30, 2022

LGTM besides the old checked in file. Sorry about that; I considered leaving it gitignored for a while after I removed it so it'd be harder to do that, but decided against it.

@weswigham
Copy link
Member Author

weswigham commented Aug 30, 2022

cc @RyanCavanaugh to follow
@typescript-bot cherry-pick this into release-4.8

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 30, 2022 •
edited
Loading

Heya @weswigham, I've started to run the task to cherry-pick this into release-4.8 on this PR at 9e0c039. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Aug 30, 2022
Closed
@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 30, 2022

Hey @weswigham, I've opened #50538 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 30, 2022
@weswigham @typescript-bot
Cherry-pick PR microsoft#50537 into release-4.8
749fc56 
Component commits:
74df98f Retain name and propertyName in declaration emit copies of binding patterns if property name is a keyword

0a5096a Accept baselines

9e0c039 Remove out of date file
@weswigham weswigham requested a review from jakebailey August 30, 2022 15:53
@weswigham weswigham merged commit 488d0ee into microsoft:main Aug 30, 2022
@jakebailey jakebailey mentioned this pull request Sep 12, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 24, 2022
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@jakebailey jakebailey Awaiting requested review from jakebailey

Assignees

@weswigham weswigham

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Isssue generating declaration files with object containing keywords as property

4 participants

@weswigham @jakebailey @typescript-bot @andrewbranch