Updates to type reference directive resolution and module resolution when failed

[sheetalkamat]

• When user has supplied typeRoots resolve the typeReference as file or directory instead of just directory resolution as before.
  1c2318d This is fix for issue Bug 2 reported in typeRoots and types not working  #37708
• If configuration has supplied typeRoots stop looking into node_modules/@types containing file's ancestor directories to resolve type reference as secondary lookup.
  40bb75c This is fix for issue Bug 1 reported in typeRoots and types not working  #37708
• When resolving modules, if resolution fails, try resolving it from typeRoots if user has supplied. This helps solve the issues with module augmentation etc if when types are included through typeRoots.
  a6fed14 This is fix for Type merging for imported types only works if the type is imported from "node_modules/@types/" dir #39691 and Folders from typesRoot should be used in looking up for types for imports as well as @types folder #37958

Fixes #37708, #39691, #37958, #44270

[andrewbranch]

Since this is technically a breaking change, we should discuss whether we think we can get it in 5.0 or wait until 5.1.

[andrewbranch]

@typescript-bot run dt
@typescript-bot test top100

[typescript-bot]

Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at 7d23697. You can monitor the build here.

[typescript-bot]

Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at 7d23697. You can monitor the build here.

[sandersn]

@sheetalkamat I'm going through all the ready-to-merge PRs, and this one was intended either for 5.0 or 5.1, so I vote to merge it now that 5.1 development has started.

[loick]

Hi there,

Just to notify something on this release. A behavior has changed for me on my monorepo orchestration.
I used to have this:

{
  "extends": "@myapp/config/tsconfig/base.json",
  "compilerOptions": {
    "noEmit": false,
    "outDir": "dist/",
    "types": ["node"],
  },
  "include": ["./src/index.ts"],
  "exclude": ["node_modules", "dist"]
}

Where my app includes in "compilerOptions" :

"typeRoots": ["../../node_modules/@types"]

After this release, I have to specify this typeRoots URL on each package. Is it on purpose?

Thanks 🙏

[ehoogeveen-medweb]

Yes, it's mentioned in the Announcing TypeScript 5.1 blog post.

Edit: Or do you mean that it's not picking it up from @myapp/config/tsconfig/base.json?

[loick]

Yes indeed, sorry maybe it was not clear.

Indeed this is not retrieving the value from @myapp/config/tsconfig/base.json in this case. I already had it before set in my tsconfig/base and it worked properly, but now I have add the typeRoots on every tsconfig file.

[RyanCavanaugh]

@loick can you log a fresh issue please? Thanks!