Skip to content

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented May 13, 2023

Fixes #53656

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 13, 2023
@andrewbranch andrewbranch mentioned this pull request Jun 1, 2023
5 tasks
@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 25, 2023
@a-tarasyuk a-tarasyuk changed the title [WIP] feat(53656): Add support for the updated import attributes proposal feat(53656): Add support for the updated import attributes proposal Aug 30, 2023
@a-tarasyuk a-tarasyuk marked this pull request as ready for review August 30, 2023 19:36
@andrewbranch
Copy link
Member

@a-tarasyuk we’d like to get this in for 5.3 beta by Friday. I think the only outstanding thing is the factory API (left a comment on the open thread). Let us know if you’d like to finish it up on such short notice; otherwise one of us can push the last commit or two by Friday. Thanks so much for your work on this!

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mark the assertion-specific overloads and functions in the node factory as deprecated?

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @a-tarasyuk! 🌟

@andrewbranch
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 22, 2023

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at e0afc4a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 22, 2023

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157875/artifacts?artifactName=tgz&fileId=33037B3AD71E60CA4A75534F246CF94A71C4950A34A8E3CB625EBD955A072DFF02&fileName=/typescript-5.3.0-insiders.20230922.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@DanielRosenwasser
Copy link
Member

Looks like a baseline needs to be updated for tests/cases/conformance/node/nodeModulesImportAssertions.ts

@DanielRosenwasser DanielRosenwasser merged commit 2e9e9a2 into microsoft:main Sep 26, 2023
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import Attributes (Stage 3)

7 participants