-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Add new option "noUncheckedSideEffectImports" #58941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@typescript-bot test it |
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
|
Hey @jakebailey, the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: array.prototype.find Package: howler Package: page-flip Package: redux-shortcuts Package: array.prototype.every Package: behavior3 Package: string.prototype.trim Package: strophe Package: bootstrap-toggle Package: mapbox__aws-sdk-jest Package: siren-parser Package: utif Package: wonder.js Package: hapi/v17 Package: baidumap-web-sdk Package: object.groupby Package: source-map-support Package: hapi Package: aws-synthetics-puppeteer Package: terminal-kit Package: babel-types Package: iitc Package: ember-feature-flags/v3 Package: npm-which Package: react-smartbanner Package: ember-feature-flags Package: smartwizard/v4 Package: browser-report Package: object.assign Package: vue-moment Package: openfin/v50 Package: smartwizard Package: bcswipe Package: pannellum Package: function.prototype.name Package: setimmediate Package: splitting Package: tablesorter Package: bootstrap4-toggle Package: format-unicorn Package: jquery-deserialize Package: vue3-carousel-3d Package: ecma-proposal-math-extensions Package: gun Package: reflect.ownkeys Package: error-cause Package: array.prototype.flatmap Package: bmapgl-browser Package: react-katex Package: array.prototype.flat Package: cloudinary-uploadwidget-browser Errors that changed between main and the branch:Package: node/v16 Branch error: Package: node/v18 Branch error: Package: node Branch error: |
|
@jakebailey Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@jakebailey Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
The user/top tests are pretty much as expected; css/sass etc. But what's more interesting are the DT results. There's a load of stuff there that is probably just plain broken on DT. |
|
100% this should not be called "bare", as I believe that actually means imports like "foo" versus "./blah" or something. Oops. |
This reverts commit b7eda58.
|
I am opening this up for review; we still need to bikeshed the name. Honestly, I'm still still thinking |
|
Good point, I should add that test. |
|
Flag name has been updated to |
andrewbranch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good after resolving Sheetal's comment about the command line description
|
Thank you! 👍 |
|
Nice work! |
When
noUncheckedSideEffectImportsis enabled, imports like:Are now resolved and can produce resolution errors.
Closes #50394
See also #58725 (comment)
TODO:
checkSideEffectImportsor somethingFuture: