Skip to content

Fix issue #1171: Order of object destruction #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BillyONeal merged 1 commit into from
Jul 12, 2019
Merged

Fix issue #1171: Order of object destruction #1175

BillyONeal merged 1 commit into from
Jul 12, 2019

Conversation

@dejaniv
Copy link
Contributor

@dejaniv dejaniv commented Jul 4, 2019

  • Connection object is now destroyed before client object
  • Client is destroyed only when wspp_callback_client is destroyed to prevent race condition with the destructor
  • make test didn't pass with or without this commit for tests: httpclient_test, httplistener_test, websocketsclient_test

Fix issue #1171: Order of object destruction
da297b1 
- Connection object is now destroyed before client object
- Client is destroyed only when wspp_callback_client is destroyed to prevent race condition with the destructor
@dejaniv
Copy link
Contributor Author

dejaniv commented Jul 5, 2019

Android build failed with error:
Undefined or not supported Android NDK version: 20.0

Other builds pass.

@BillyONeal
Copy link
Member

BillyONeal commented Jul 12, 2019

Thanks for your contribution!

@BillyONeal BillyONeal merged commit 06aeb8e into microsoft:master Jul 12, 2019
@dejaniv dejaniv deleted the patch-1 branch July 18, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dejaniv @BillyONeal