FIX: GH Issue #333 "cursor.execute() with INSERT statement containing OUTPUT inserted + multiple VALUES entries does not raise IntegrityError"

[gargsaumya]

Work Item / Issue Reference

AB#40543

GitHub Issue: #333

---

Summary

This pull request introduces an error handling improvement to the fetchall method in mssql_python/cursor.py. The change ensures that errors from the fetch operation are properly checked and handled.

Error handling enhancement:

• Added a call to check_error after fetching data in the fetchall method to verify and handle any errors returned by DDBCSQLFetchAll.

[Copilot]

Pull Request Overview

This pull request fixes GitHub Issue #333, which addresses a bug where fetchall() does not properly raise IntegrityError when executing INSERT statements with OUTPUT clauses that violate integrity constraints. The fix adds error checking after the fetch operation to ensure errors are properly detected and raised.

Key Changes:

• Added check_error() call after DDBCSQLFetchAll() in the fetchall() method to properly handle and raise errors returned by the fetch operation
• This brings fetchall() into consistency with other DDBC binding calls throughout the codebase that use check_error() for error handling

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

📊 Code Coverage Report

🔥 Diff Coverage 100%

🎯 Overall Coverage 75%

📈 Total Lines Covered: 5092 out of 6749 📁 Project: mssql-python

---

Diff Coverage

Diff: main...HEAD, staged and unstaged changes

• mssql_python/cursor.py (100%)

Summary

• Total: 2 lines
• Missing: 0 lines
• Coverage: 100%

---

📋 Files Needing Attention

📉 Files with overall lowest coverage (click to expand)

mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.pybind.ddbc_bindings.cpp: 67.1%
mssql_python.helpers.py: 67.5%
mssql_python.pybind.connection.connection.cpp: 74.7%
mssql_python.pybind.ddbc_bindings.h: 76.9%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 82.5%
mssql_python.cursor.py: 83.8%

---

🔗 Quick Links

⚙️ Build Summary	📋 Coverage Details
View Azure DevOps Build	Browse Full Coverage Report

[saurabh500]

Considering the fix is for making sure that the errors are thrown in fetch* API, a test should be added to validate this behavior.

[saurabh500]

Need tests for conditions where the silent failure is now avoided

[sumitmsft]

As discussed, please resolve this PR and add new issues for other fetch* apis on GH and corresponding bugs in ADO. Please label the GH issues appropriately.

Added the requested test. For the other fetch APIs, the return-code checks will be added in an upcoming PR that also fixes an issue we’ve identified in those APIs.

Thanks.