Clarify value must be a valid JS expression in let #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed code at Line 95 as the given code is not working while previewing POML. Previous: <let name="greeting" value="Hello, world!" /> New: <let name="greeting">Hello, world!</let>
Contributor
|
Oh really? I'm a little surprised. Let me test it later. |
Contributor
|
I think the correct version should be Or you can allow me to edit this pull request if you don't have time to do that. |
ultmaster
changed the title
Contributor
Author
|
Thanks for the clarification! |
Contributor
|
@Kartikey-Garg please address the CLA. |
Contributor
Author
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed code at Line 95 as the given code is not working while previewing POML.
Previous:
New:
Hello, world!