Skip to content

Conversation

@ultmaster
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings August 20, 2025 15:32
@ultmaster ultmaster enabled auto-merge (squash) August 20, 2025 15:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes GitHub Actions workflow issues by updating file paths and correcting example filenames in the daily testing workflow.

  • Replaces hardcoded /tmp/poml_test paths with ${{ runner.temp }}/poml_test for better cross-platform compatibility
  • Updates example filenames from pomljs/pomlpy to js/py naming convention
  • Adds -f flag to the poml-cli command and ensures consistent shell specification

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cp -r examples /tmp/poml_test/
mkdir -p ${{ runner.temp }}/poml_test
cp -r examples ${{ runner.temp }}/poml_test/
shell: bash
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shell specification is inconsistent across steps. Some steps specify 'shell: bash' while others don't. For consistency and reliability, all steps that run shell commands should explicitly specify the shell.

Copilot uses AI. Check for mistakes.
@ultmaster ultmaster merged commit 1fca1ab into main Aug 20, 2025
7 checks passed
@ultmaster ultmaster deleted the codex/add-github-actions-daily-test-for-pomljs-and-poml-python branch August 27, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants