Skip to content

Conversation

@ultmaster
Copy link
Contributor

Summary

  • switch parser value from expr to eval for schemas and tools
  • document and test the parser="eval" attribute for response schemas and tool definitions

Testing

  • npm run build-webview
  • npm run build-cli
  • npm run lint
  • npm test
  • pytest python/tests

https://chatgpt.com/codex/tasks/task_e_68a6680bc2fc832e8f318fbef783d1cf

Copilot AI review requested due to automatic review settings August 21, 2025 02:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the lang attribute to parser for schema and tool definition elements, and changes the parser value from expr to eval for expression-based schemas and tools.

  • Replaces all instances of lang attribute with parser in schema and tool elements
  • Changes expression parser value from expr to eval
  • Updates documentation and test cases to reflect the new naming convention

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/poml/tests/file.test.tsx Updates all test cases to use parser="eval" and parser="json" instead of lang="expr" and lang="json"
packages/poml/file.tsx Updates core file processing logic to use parser attribute instead of lang and handle eval instead of expr
docs/vscode/features.md Updates documentation examples to use parser="eval"
docs/language/standalone.md Updates comprehensive documentation to use parser attribute and eval value throughout examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ultmaster ultmaster merged commit 380702e into main Aug 21, 2025
7 checks passed
@ultmaster ultmaster deleted the codex/rename-lang-to-parser-in-schema-m9v2za branch August 27, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants