Skip to content

Conversation

@ultmaster
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings August 21, 2025 13:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates integration testing workflows and improves test output formatting. It refactors GitHub Actions to use shared workflow patterns and standardizes status messages across test utilities.

  • Replaces individual GitHub Action composite actions with a reusable workflow pattern
  • Updates test output messages to use bracketed prefixes ([OK], [ERROR], [SUCCESS])
  • Adds missing dependencies to support langchain integration tests

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
python/tests/integration/weave_utils.py Updates status messages to use bracketed format for consistency
python/tests/integration/mlflow_utils.py Updates status messages to use bracketed format for consistency
python/tests/integration/common_utils.py Fixes print_separator formatting to apply color to title text
pyproject.toml Adds langchain-openai and openai dependencies for agent extras
.github/workflows/test-integration.yml Refactors to use shared workflow instead of composite action
.github/workflows/shared-test-integration.yml New reusable workflow consolidating integration test logic
.github/workflows/shared-check-version.yml Renames workflow for consistency with shared naming pattern
.github/workflows/publish-vscode.yml Updates reference to renamed shared workflow
.github/workflows/publish-pypi.yml Updates reference to renamed shared workflow
.github/workflows/publish-npm.yml Updates reference to renamed shared workflow
.github/actions/test-integration/action.yml Removes composite action replaced by shared workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


- name: Setup MLflow tracking server
if: inputs.integration == 'mlflow'
run: |
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MLflow server command has added --default-artifact-root ./mlartifacts parameter that wasn't present in the original action. This change should be documented or verified as intentional to ensure artifact storage works correctly.

Suggested change
run: |
run: |
# Use a custom artifact root to avoid polluting the default ./mlruns directory in CI.
mkdir -p ./mlartifacts

Copilot uses AI. Check for mistakes.
@ultmaster ultmaster merged commit 184a5a6 into main Aug 21, 2025
16 checks passed
@ultmaster ultmaster deleted the integration-tests branch August 27, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants