-
Notifications
You must be signed in to change notification settings - Fork 254
Integration test fixes #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates integration testing workflows and improves test output formatting. It refactors GitHub Actions to use shared workflow patterns and standardizes status messages across test utilities.
- Replaces individual GitHub Action composite actions with a reusable workflow pattern
- Updates test output messages to use bracketed prefixes ([OK], [ERROR], [SUCCESS])
- Adds missing dependencies to support langchain integration tests
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| python/tests/integration/weave_utils.py | Updates status messages to use bracketed format for consistency |
| python/tests/integration/mlflow_utils.py | Updates status messages to use bracketed format for consistency |
| python/tests/integration/common_utils.py | Fixes print_separator formatting to apply color to title text |
| pyproject.toml | Adds langchain-openai and openai dependencies for agent extras |
| .github/workflows/test-integration.yml | Refactors to use shared workflow instead of composite action |
| .github/workflows/shared-test-integration.yml | New reusable workflow consolidating integration test logic |
| .github/workflows/shared-check-version.yml | Renames workflow for consistency with shared naming pattern |
| .github/workflows/publish-vscode.yml | Updates reference to renamed shared workflow |
| .github/workflows/publish-pypi.yml | Updates reference to renamed shared workflow |
| .github/workflows/publish-npm.yml | Updates reference to renamed shared workflow |
| .github/actions/test-integration/action.yml | Removes composite action replaced by shared workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| - name: Setup MLflow tracking server | ||
| if: inputs.integration == 'mlflow' | ||
| run: | |
Copilot
AI
Aug 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MLflow server command has added --default-artifact-root ./mlartifacts parameter that wasn't present in the original action. This change should be documented or verified as intentional to ensure artifact storage works correctly.
| run: | | |
| run: | | |
| # Use a custom artifact root to avoid polluting the default ./mlruns directory in CI. | |
| mkdir -p ./mlartifacts |
Co-authored-by: Copilot <[email protected]>
No description provided.