-
Notifications
You must be signed in to change notification settings - Fork 254
Ensure the correctness of examples #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: File Directory Change Breaks Relative Path Resolution
The working directory determination logic was changed by removing the behavior where it defaulted to the input file's directory when args.file was provided without args.cwd. Previously, relative paths within files (e.g., context, stylesheet, or other resources) were resolved relative to the input file's location. Now, the working directory always defaults to process.cwd(), which breaks existing functionality by causing relative path resolution issues for files that expect resources to be resolved relative to their own directory.
packages/poml/index.ts#L118-L124
Lines 118 to 124 in 4ff33e3
| // Determine the working directory | |
| let workingDirectory: string; | |
| if (args.cwd) { | |
| workingDirectory = path.resolve(args.cwd); | |
| } else { | |
| workingDirectory = process.cwd(); | |
| } |
Was this report helpful? Give feedback by reacting with 👍 or 👎
No description provided.