Fix whitespace between images in example #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses formatting issues by fixing extra blank lines between images in the example file and removing unwanted whitespace between sequential multimedia nodes in the Markdown writer.
- Removes extra newlines in 104_financial_analysis.txt
- Adds logic to conditionally remove spaces between multimedia-only nodes in MarkdownWriter
- Updates documentation comments to describe the new whitespace handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/poml/writer.ts | Updates whitespace removal logic to handle consecutive multimedia nodes and improves explanatory comments |
| examples/expects/104_financial_analysis.txt | Removes superfluous blank lines between images |
| // When a whitespace-only box is sandwiched between two multimedia | ||
| // boxes (e.g., two consecutive images), we treat it like the spaces | ||
| // around a block element so it doesn't generate a blank line. | ||
| const afterMedia = |
There was a problem hiding this comment.
Consider extracting the multimedia-only node checks (lines 694-701) into a separate helper function to improve readability and ease future maintenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
104_financial_analysis.txtMarkdownWriterTesting
npm run build-webviewnpm run build-clinpm run lintnpm testpython -m pytest python/testshttps://chatgpt.com/codex/tasks/task_e_686379e79f90832eb96dcfa9550070c3