-
Notifications
You must be signed in to change notification settings - Fork 254
Add azure-pipelines yaml #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an Azure Pipelines configuration to automate downloading build artifacts from GitHub Actions and publishing VSIX packages to the VS Code Marketplace as well as Python wheels to PyPI. Key changes include:
- New
azure-pipelines.ymldefining stages for artifact download, VSIX publication, and PyPI upload. - New
.env.azure-pipelinesplaceholder file for storing pipeline secrets.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| azure-pipelines.yml | Defines pipeline steps for Node/Python setup, artifact download, VSIX and wheel publication |
| .env.azure-pipelines | Lists required secret variables (VSCE_PAT, GITHUB_PAT, PYPI_TOKEN) |
Comments suppressed due to low confidence (3)
azure-pipelines.yml:43
- Within the script block, environment variables should use
$GITHUB_PATinstead of$(GITHUB_PAT), otherwise$(GITHUB_PAT)will be treated as a command substitution and fail.
artifacts_response=$(curl -s -H "Authorization: token $(GITHUB_PAT)" \
azure-pipelines.yml:114
- [nitpick] Both branches of this conditional invoke the same
vsce publishcommand. You can simplify by removing theif/elseand calling the single command once, or restore the intended--targetflag in the non-universal case.
if [ "$target" = "universal" ]; then
azure-pipelines.yml:1
trigger: noneandpr: nonedisable all automatic runs. If you want CI on pushes or PRs, configure appropriate branch or path triggers here.
trigger: none
| @@ -0,0 +1,10 @@ | |||
| # Get the token from https://dev.azure.com/yugzhan/_usersSettings/tokens | |||
Copilot
AI
Jul 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding .env.azure-pipelines to .gitignore or managing these secrets via Azure variable groups or Key Vault to avoid accidental exposure of real tokens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Hardcoded Run ID Limits Pipeline Flexibility
The RUN_ID variable is hardcoded to a specific GitHub Actions run ID ('15574923104'). This prevents the pipeline from downloading artifacts from different GitHub Actions runs, severely limiting its reusability. This value should be parameterized or dynamically obtained, as it appears to be a test/debug value accidentally committed.
azure-pipelines.yml#L11-L12
Lines 11 to 12 in 8604bcf
| - name: RUN_ID | |
| value: '15574923104' |
Bug: VSIX Publishing Bug: Missing Target Parameter
The Azure Pipeline's 'Publish VSIX Files to Marketplace' step incorrectly publishes all VSIX files as universal packages because the vsce publish command for platform-specific targets is missing the --target parameter. This renders the conditional publishing logic ineffective. The pipeline also contains commented-out debug statements and the intended vsce publish --target command, which are leftover development code and should be removed.
azure-pipelines.yml#L113-L123
Lines 113 to 123 in 8604bcf
| # Target already set at packaging so it's not needed here | |
| if [ "$target" = "universal" ]; then | |
| echo "Publishing as universal package..." | |
| # echo "vsce publish --packagePath \"$vsix_file\" --pat $(VSCE_PAT)" | |
| vsce publish --packagePath "$vsix_file" --pat $(VSCE_PAT) | |
| else | |
| echo "Publishing with target: $target" | |
| # echo "vsce publish --packagePath \"$vsix_file\" --target \"$target\" --pat $(VSCE_PAT)" | |
| # vsce publish --packagePath "$vsix_file" --target "$target" --pat $(VSCE_PAT) | |
| vsce publish --packagePath "$vsix_file" --pat $(VSCE_PAT) | |
| fi |
BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
No description provided.