Skip to content

Conversation

@ultmaster
Copy link
Contributor

No description provided.

@ultmaster ultmaster marked this pull request as ready for review August 12, 2025 15:34
Copilot AI review requested due to automatic review settings August 12, 2025 15:34

This comment was marked as outdated.

@ultmaster ultmaster requested a review from Copilot August 12, 2025 15:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a nightly build system for the POML project, bumping the version from 0.0.7 to 0.0.8 and adding comprehensive CI/CD workflows for publishing to multiple platforms.

  • Adds automated version bumping script supporting nightly and development builds
  • Implements multi-platform build and publish workflows for NPM, PyPI, and VSCode extensions
  • Enhances version comparison logic to handle nightly/development versions

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
python/poml/_version.py Version bump from 0.0.7 to 0.0.8
pyproject.toml Version bump from 0.0.7 to 0.0.8
packages/poml/version.ts Version bump from 0.0.7 to 0.0.8
packages/poml/file.tsx Enhanced version comparison to support nightly builds
packages/poml-build/package.json Version bump from 0.0.7 to 0.0.8
package.json Version bump from 0.0.7 to 0.0.8
bump-version.js New script for automated version management
.github/workflows/* New CI/CD workflows for publishing and nightly builds

return -1;
const parseVersion = (version: string) => {
// Handle nightly versions: "1.2.3-nightly.202508120345"
const nightlyMatch = version.match(/^(\d+\.\d+\.\d+)-nightly\.(\d+)$/);
Copy link

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern should include validation for the dev format mentioned in the comment but not handled in the implementation. The comment states support for 'x.y.z.devtimestamp' but only handles nightly format.

Copilot uses AI. Check for mistakes.
mode = 'python';
} else if (timestampOrFlag === '--nodejs-only') {
mode = 'nodejs';
} else if (/^\d{12,14}$/.test(timestampOrFlag)) {
Copy link

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern allows 12-14 digits but the usage examples show YYYYMMDDHHMM (12 digits) or YYYYMMDDHHMMSS (14 digits). Consider making this more explicit with separate patterns for each format to improve clarity.

Suggested change
} else if (/^\d{12,14}$/.test(timestampOrFlag)) {
} else if (/^(\d{12}|\d{14})$/.test(timestampOrFlag)) {

Copilot uses AI. Check for mistakes.
@ultmaster ultmaster enabled auto-merge (squash) August 12, 2025 16:31
@ultmaster ultmaster merged commit b130fa3 into main Aug 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants