fatal error: concurrent map read and map write

[tmm1]

Stack trace

Run tsgo --noEmit --extendedDiagnostics -p .
fatal error: concurrent map read and map write

goroutine 55339 [running]:
internal/runtime/maps.fatal({0xc48fb9?, 0x0?})
	/home/ubuntu/ci-selfhosted/actions-runner-6/_work/_tool/go/1.24.0/x64/src/runtime/panic.go:1053 +0x18
github.com/microsoft/typescript-go/internal/core.(*LinkStore[...]).Get(0xd8f480, 0xc05f51d348)
	tsgo-src/internal/core/linkstore.go:11 +0x36
github.com/microsoft/typescript-go/internal/checker.(*Checker).markSymbolOfAliasDeclarationIfTypeOnly(0xc05f5a8608, 0xc0464fd920, 0xc05f516548, 0x0, 0x1, 0x0, {0x0, 0x0})
	tsgo-src/internal/checker/checker.go:14395 +0x16b
github.com/microsoft/typescript-go/internal/checker.(*Checker).resolveEntityName(0xc05f5a8608, 0xc0457f1080, 0xdbfff, 0xc0?, 0x0, 0x0?)
	tsgo-src/internal/checker/checker.go:15056 +0x2ba
github.com/microsoft/typescript-go/internal/checker.(*Checker).getTargetOfExportSpecifier(0xc05f5a8608, 0xc0464fd920, 0xdbfff, 0x0)
	tsgo-src/internal/checker/checker.go:14271 +0xfe
github.com/microsoft/typescript-go/internal/checker.(*Checker).getTargetOfAliasDeclaration(0xc05f5a8ee8?, 0xd8f480?, 0x48?)
	tsgo-src/internal/checker/checker.go:15002 +0x170
github.com/microsoft/typescript-go/internal/checker.(*Checker).resolveAlias(0xc05f5a8608, 0xc05f51d348)
	tsgo-src/internal/checker/checker.go:15478 +0x145
github.com/microsoft/typescript-go/internal/checker.(*Checker).GetAliasedSymbol(...)
	tsgo-src/internal/checker/checker.go:30670
github.com/microsoft/typescript-go/internal/checker.SkipAlias(...)
	tsgo-src/internal/checker/utilities.go:1884
github.com/microsoft/typescript-go/internal/incremental.(*affectedFilesHandler).handleDtsMayChangeOfAffectedFile(0xc05fc862a0, 0xc05637e3c0, 0xc0464f5b88)
	tsgo-src/internal/incremental/affectedfileshandler.go:237 +0x3e5
github.com/microsoft/typescript-go/internal/incremental.collectAllAffectedFiles.func2.1()
	tsgo-src/internal/incremental/affectedfileshandler.go:385 +0x1f
github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue.func1()
	tsgo-src/internal/core/workgroup.go:39 +0x50
created by github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue in goroutine 1
	tsgo-src/internal/core/workgroup.go:37 +0x85

goroutine 1 [sync.WaitGroup.Wait]:
sync.runtime_SemacquireWaitGroup(0x9d5e36?)
	/home/ubuntu/ci-selfhosted/actions-runner-6/_work/_tool/go/1.24.0/x64/src/runtime/sema.go:110 +0x25
sync.(*WaitGroup).Wait(0xc00d71a008?)
	/home/ubuntu/ci-selfhosted/actions-runner-6/_work/_tool/go/1.24.0/x64/src/sync/waitgroup.go:118 +0x48
github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).RunAndWait(0xc0362123d8?)
	tsgo-src/internal/core/workgroup.go:45 +0x45
github.com/microsoft/typescript-go/internal/incremental.collectAllAffectedFiles({0xd8a528, 0x1334640}, 0xc03187d200)
	tsgo-src/internal/incremental/affectedfileshandler.go:389 +0x43a
github.com/microsoft/typescript-go/internal/incremental.(*Program).collectSemanticDiagnosticsOfAffectedFiles(0xc03187d200, {0xd8a528, 0x1334640}, 0x0)
	tsgo-src/internal/incremental/program.go:196 +0x4e
github.com/microsoft/typescript-go/internal/incremental.(*Program).GetSemanticDiagnostics(0xc03187d200, {0xd8a528, 0x1334640}, 0x0)
	tsgo-src/internal/incremental/program.go:127 +0x6b
github.com/microsoft/typescript-go/internal/execute.emitFilesAndReportErrors.func2({0xd8a528, 0x1334640}, 0x0)
	tsgo-src/internal/execute/tsc.go:360 +0xa2
github.com/microsoft/typescript-go/internal/compiler.GetDiagnosticsOfAnyProgram({0xd8a528, 0x1334640}, {0xd8fe40, 0xc03187d200}, 0x0, 0x0, 0xc00d71a458, 0xc00d71a428)
	tsgo-src/internal/compiler/program.go:1377 +0x3d5
github.com/microsoft/typescript-go/internal/execute.emitFilesAndReportErrors({0xd8d1d0, 0xc000136720}, {0xd8fe40, 0xc03187d200}, 0xc00024db80)
	tsgo-src/internal/execute/tsc.go:344 +0x114
github.com/microsoft/typescript-go/internal/execute.emitAndReportStatistics({0xd8d1d0, 0xc000136720}, {0xd8fe40?, 0xc03187d200?}, 0xc000483880, 0xc000198000, 0x0?, 0x1ee798e, 0x172e627f)
	tsgo-src/internal/execute/tsc.go:297 +0x6d
github.com/microsoft/typescript-go/internal/execute.performIncrementalCompilation({0xd8d1d0, 0xc000136720}, 0xc000198000, 0xc00024db80, 0xc00012f980, 0x1ee798e, 0x0)
	tsgo-src/internal/execute/tsc.go:246 +0x316
github.com/microsoft/typescript-go/internal/execute.tscCompilation({0xd8d1d0, 0xc000136720}, 0xc0001980f0, 0x0)
	tsgo-src/internal/execute/tsc.go:194 +0xb53
github.com/microsoft/typescript-go/internal/execute.CommandLine({0xd8d1d0, 0xc000136720}, {0xc000138010, 0x4, 0x4}, 0x0)
	tsgo-src/internal/execute/tsc.go:63 +0x17e
main.runMain()
	tsgo-src/cmd/tsgo/main.go:23 +0x109
main.main()
	tsgo-src/cmd/tsgo/main.go:10 +0x13

goroutine 55335 [runnable]:
github.com/microsoft/typescript-go/internal/collections.(*SyncSet[...]).Add(0xd90700, {0xc01351b980?, 0x76?})
	tsgo-src/internal/collections/syncset.go:12 +0x7a
github.com/microsoft/typescript-go/internal/incremental.(*affectedFilesHandler).removeSemanticDiagnosticsOf(...)
	tsgo-src/internal/incremental/affectedfileshandler.go:49
github.com/microsoft/typescript-go/internal/incremental.(*affectedFilesHandler).handleDtsMayChangeOf(0xc05fc862a0, 0xc05637e1b0, {0xc01351b980, 0x76}, 0x0)
	tsgo-src/internal/incremental/affectedfileshandler.go:314 +0xae
github.com/microsoft/typescript-go/internal/incremental.(*affectedFilesHandler).handleDtsMayChangeOfFileAndExportsOfFile(0xc05fc862a0, 0xc05637e1b0, {0xc01351b980, 0x76}, 0x0)
	tsgo-src/internal/incremental/affectedfileshandler.go:279 +0xda
github.com/microsoft/typescript-go/internal/incremental.(*affectedFilesHandler).handleDtsMayChangeOfFileAndExportsOfFile(0xc05fc862a0, 0xc05637e1b0, {0xc013cb4380, 0x73}, 0x0)
	tsgo-src/internal/incremental/affectedfileshandler.go:284 +0x18d
github.com/microsoft/typescript-go/internal/incremental.(*affectedFilesHandler).handleDtsMayChangeOfFileAndExportsOfFile(0xc05fc862a0, 0xc05637e1b0, {0xc001af50a0, 0x6c}, 0x0)
	tsgo-src/internal/incremental/affectedfileshandler.go:284 +0x18d
github.com/microsoft/typescript-go/internal/incremental.(*affectedFilesHandler).handleDtsMayChangeOfFileAndExportsOfFile(0xc05fc862a0, 0xc05637e1b0, {0xc022daaf50, 0x6e}, 0x0)
	tsgo-src/internal/incremental/affectedfileshandler.go:284 +0x18d
github.com/microsoft/typescript-go/internal/incremental.(*affectedFilesHandler).handleDtsMayChangeOfAffectedFile(0xc05fc862a0, 0xc05637e1b0, 0xc03424a2c8)
	tsgo-src/internal/incremental/affectedfileshandler.go:263 +0x33a
github.com/microsoft/typescript-go/internal/incremental.collectAllAffectedFiles.func2.1()
	tsgo-src/internal/incremental/affectedfileshandler.go:385 +0x1f
github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue.func1()
	tsgo-src/internal/core/workgroup.go:39 +0x50
created by github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue in goroutine 1
	tsgo-src/internal/core/workgroup.go:37 +0x85

goroutine 55330 [runnable]:
internal/sync.(*entry[...]).lookup(...)
	/home/ubuntu/ci-selfhosted/actions-runner-6/_work/_tool/go/1.24.0/x64/src/internal/sync/hashtriemap.go:581
internal/sync.(*HashTrieMap[...]).LoadOrStore(0xda6580, {0xa8ade0, 0xc05b876e30}, {0xa548c0, 0xda7ac0})
	/home/ubuntu/ci-selfhosted/actions-runner-6/_work/_tool/go/1.24.0/x64/src/internal/sync/hashtriemap.go:114 +0x586
sync.(*Map).LoadOrStore(...)
	/home/ubuntu/ci-selfhosted/actions-runner-6/_work/_tool/go/1.24.0/x64/src/sync/hashtriemap.go:67
github.com/microsoft/typescript-go/internal/collections.(*SyncMap[...]).LoadOrStore(0xda04a0, {0xc025143b00, 0xc04002f0c0?}, 0x0?)
	tsgo-src/internal/collections/syncmap.go:22 +0x6a
github.com/microsoft/typescript-go/internal/incremental.(*affectedFilesHandler).handleDtsMayChangeOfFileAndExportsOfFile(0xc05fc862a0, 0xc0567b7e90, {0xc025143b00, 0x73}, 0x0)
	tsgo-src/internal/incremental/affectedfileshandler.go:273 +0x56
github.com/microsoft/typescript-go/internal/incremental.(*affectedFilesHandler).handleDtsMayChangeOfAffectedFile(0xc05fc862a0, 0xc0567b7e90, 0xc03404b348)
	tsgo-src/internal/incremental/affectedfileshandler.go:263 +0x33a
github.com/microsoft/typescript-go/internal/incremental.collectAllAffectedFiles.func2.1()
	tsgo-src/internal/incremental/affectedfileshandler.go:385 +0x1f
github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue.func1()
	tsgo-src/internal/core/workgroup.go:39 +0x50
created by github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue in goroutine 1
	tsgo-src/internal/core/workgroup.go:37 +0x85

Steps to reproduce

1. not sure, happened maybe once in 500 runs

[tmm1]

tsgo-src/internal/incremental/affectedfileshandler

perhaps related to #1465

i removed --incremental but forgot its still in my tsconfig.json

[tmm1]

Passing --incremental false isn't working, so I'll have to roll back to before the incremental merge.

error TS6379: Composite projects may not disable incremental compilation.

[jakebailey]

Can you build the repo with --race and then see what the error is?

[jakebailey]

The problem here will be that handleDtsMayChangeOfAffectedFile is touching the checker without locking stuff, of course.

[kallevmercury]

I am replicating an intermittent crash with incremental builds setup too, although the stacktrace looks more like the one linked in this issue: #1465

Version: 7.0.0-dev.20250728.1

Example:

runtime: goroutine stack exceeds 1000000000-byte limit
runtime: sp=0x140d55aa390 stack=[0x140d55aa000, 0x140f55aa000]
fatal error: stack overflow

runtime stack:
runtime.throw({0x104a55ec1?, 0x0?})
runtime/panic.go:1101 +0x38 fp=0x16cbaed90 sp=0x16cbaed60 pc=0x104553cf8
runtime.newstack()
runtime/stack.go:1107 +0x45c fp=0x16cbaeed0 sp=0x16cbaed90 pc=0x10453b55c
runtime.morestack()
runtime/asm_arm64.s:342 +0x70 fp=0x16cbaeed0 sp=0x16cbaeed0 pc=0x104559c80

My current workaround has been to remove the incremental build cache file: tsconfig.tsbuildinfo. Otherwise, the stack overflow errors will persist once they start happening.

Update:
This is still happening with 7.0.0-dev.20250808.1.

[vpontis]

Yea once I get into a state where this is broken I can't fix it without removing the incremental build cache file. Thanks for the tip @kallevmercury.

[jay-l-e-e]

+1

[jay-l-e-e]

It happened once in 10 tries within a github workflows with @typescript/native-preview": "^7.0.0-dev.20250923.1

{
  "compilerOptions": {
    "allowSyntheticDefaultImports": true,
    "declaration": true,
    "emitDecoratorMetadata": true,
    "esModuleInterop": true,
    "experimentalDecorators": true,
    "incremental": true,
    "lib": ["ESNext"],
    "module": "NodeNext",
    "moduleResolution": "NodeNext",
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noImplicitReturns": true,
    "noImplicitAny": true,
    "outDir": "./distributions",
    "paths": {
      "*": ["./*"]
    },
    "rootDirs": ["sources"],
    "strict": true,
    "sourceMap": true,
    "strictNullChecks": true,
    "skipLibCheck": true,
    "target": "ESNext",
    "types": ["node"],
    "verbatimModuleSyntax": true
  }
}

npm error > @vcms-io/utils@0.0.1-alpha.1 build
npm error > tsgo
npm error fatal error: concurrent map read and map write
npm error
npm error goroutine 1907 [running]:
npm error internal/runtime/maps.fatal({0xd0954b?, 0xc0025f4af8?})
npm error 	runtime/panic.go:1046 +0x18
npm error github.com/microsoft/typescript-go/internal/core.(*LinkStore[...]).Get(0xe72900, 0xc002f20878)
npm error 	github.com/microsoft/typescript-go/internal/core/linkstore.go:11 +0x36
npm error github.com/microsoft/typescript-go/internal/checker.(*Checker).resolveAlias(0xc0011d6608, 0xc002f20878)
npm error 	github.com/microsoft/typescript-go/internal/checker/checker.go:15515 +0x3f
npm error github.com/microsoft/typescript-go/internal/checker.(*Checker).getSymbolFlagsEx(0xc0011d6608, 0xc002f20878, 0x78?, 0x0)
npm error 	github.com/microsoft/typescript-go/internal/checker/checker.go:15626 +0x15d
npm error github.com/microsoft/typescript-go/internal/checker.(*Checker).getSymbolFlags(...)
npm error 	github.com/microsoft/typescript-go/internal/checker/checker.go:15598
npm error github.com/microsoft/typescript-go/internal/checker.(*Checker).getSymbol(0xc0011d6608, 0x879434?, {0xc0004e787d?, 0x888074?}, 0xdbfff)
npm error 	github.com/microsoft/typescript-go/internal/checker/checker.go:2071 +0xae
npm error github.com/microsoft/typescript-go/internal/binder.(*NameResolver).lookup(0xc001fdee00?, 0xc0020b4480?, {0xc0004e787d?, 0xc002280c68?}, 0x417dca?)
npm error 	github.com/microsoft/typescript-go/internal/binder/nameresolver.go:425 +0x65
npm error github.com/microsoft/typescript-go/internal/binder.(*NameResolver).Resolve(0xc001fdf340, 0xc0020d0fe0, {0xc0004e787d, 0xe}, 0xdbfff, 0x144ade0, 0x1, 0x0)
npm error 	github.com/microsoft/typescript-go/internal/binder/nameresolver.go:52 +0x2f3
npm error github.com/microsoft/typescript-go/internal/checker.(*Checker).resolveEntityName(0xc0011d6608, 0xc0020d0fe0, 0xdbfff, 0x0?, 0x0, 0x0?)
npm error 	github.com/microsoft/typescript-go/internal/checker/checker.go:15085 +0x13b
npm error github.com/microsoft/typescript-go/internal/checker.(*Checker).getTargetOfExportSpecifier(0xc0011d6608, 0xc001e78fc0, 0xdbfff, 0x0)
npm error 	github.com/microsoft/typescript-go/internal/checker/checker.go:14315 +0xfe
npm error github.com/microsoft/typescript-go/internal/checker.(*Checker).getTargetOfAliasDeclaration(0xc0011d6ee8?, 0xe72900?, 0x68?)
npm error 	github.com/microsoft/typescript-go/internal/checker/checker.go:15046 +0x170
npm error github.com/microsoft/typescript-go/internal/checker.(*Checker).resolveAlias(0xc0011d6608, 0xc002f20c68)
npm error 	github.com/microsoft/typescript-go/internal/checker/checker.go:15522 +0x145
npm error github.com/microsoft/typescript-go/internal/checker.(*Checker).GetAliasedSymbol(...)
npm error 	github.com/microsoft/typescript-go/internal/checker/checker.go:30780
npm error github.com/microsoft/typescript-go/internal/checker.SkipAlias(...)
npm error 	github.com/microsoft/typescript-go/internal/checker/utilities.go:1884
npm error github.com/microsoft/typescript-go/internal/execute/incremental.(*affectedFilesHandler).handleDtsMayChangeOfAffectedFile(0xc002cff180, 0xc0033f77a0, 0xc0020de908)
npm error 	github.com/microsoft/typescript-go/internal/execute/incremental/affectedfileshandler.go:234 +0x36d
npm error github.com/microsoft/typescript-go/internal/execute/incremental.collectAllAffectedFiles.func2.1()
npm error 	github.com/microsoft/typescript-go/internal/execute/incremental/affectedfileshandler.go:376 +0x1f
npm error github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue.func1()
npm error 	github.com/microsoft/typescript-go/internal/core/workgroup.go:42 +0x50
npm error created by github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue in goroutine 1
npm error 	github.com/microsoft/typescript-go/internal/core/workgroup.go:40 +0x85
npm error
npm error goroutine 1 [sync.WaitGroup.Wait]:
npm error sync.runtime_SemacquireWaitGroup(0xa51756?, 0x30?)
npm error 	runtime/sema.go:114 +0x2e
npm error sync.(*WaitGroup).Wait(0xc001d7e1e8)
npm error 	sync/waitgroup.go:206 +0x85
npm error github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).RunAndWait(0x4198b1?)
npm error 	github.com/microsoft/typescript-go/internal/core/workgroup.go:48 +0x45
npm error github.com/microsoft/typescript-go/internal/execute/incremental.collectAllAffectedFiles({0xe6d308, 0x148d9e0}, 0xc001570db0)
npm error 	github.com/microsoft/typescript-go/internal/execute/incremental/affectedfileshandler.go:380 +0x2de
npm error github.com/microsoft/typescript-go/internal/execute/incremental.(*Program).collectSemanticDiagnosticsOfAffectedFiles(0xc001570db0, {0xe6d308, 0x148d9e0}, 0x0)
npm error 	github.com/microsoft/typescript-go/internal/execute/incremental/program.go:212 +0x4e
npm error github.com/microsoft/typescript-go/internal/execute/incremental.(*Program).GetSemanticDiagnostics(0xc001570db0, {0xe6d308, 0x148d9e0}, 0x0)
npm error 	github.com/microsoft/typescript-go/internal/execute/incremental/program.go:140 +0x68
npm error github.com/microsoft/typescript-go/internal/execute/tsc.EmitFilesAndReportErrors.func2({0xe6d308, 0x148d9e0}, 0x0)
npm error 	github.com/microsoft/typescript-go/internal/execute/tsc/emit.go:89 +0x86
npm error github.com/microsoft/typescript-go/internal/compiler.GetDiagnosticsOfAnyProgram({0xe6d308, 0x148d9e0}, {0xe73330, 0xc001570db0}, 0x0, 0x0, 0xc0001462c8, 0xc000146240)
npm error 	github.com/microsoft/typescript-go/internal/compiler/program.go:1498 +0x3d5
npm error github.com/microsoft/typescript-go/internal/execute/tsc.EmitFilesAndReportErrors({{0xe71e58, 0xc000088780}, {0xe73330, 0xc001570db0}, 0xc00011e3c0, 0xc000139560, 0xc0000b1580, 0xd51268, {0xe6a040, 0xc000092018}, ...})
npm error 	github.com/microsoft/typescript-go/internal/execute/tsc/emit.go:73 +0x175
npm error github.com/microsoft/typescript-go/internal/execute/tsc.EmitAndReportStatistics({{0xe71e58, 0xc000088780}, {0xe73330, 0xc001570db0}, 0xc00011e3c0, 0xc000139560, 0xc0000b1580, 0xd51268, {0xe6a040, 0xc000092018}, ...})
npm error 	github.com/microsoft/typescript-go/internal/execute/tsc/emit.go:43 +0x78
npm error github.com/microsoft/typescript-go/internal/execute.performIncrementalCompilation({0xe71e58, 0xc000088780}, 0xc000139560, 0xc0000b1580, 0xd51268, {0xe6a540, 0xc0000a58f0}, 0xc0000ef4c0, {0x0, 0x0})
npm error 	github.com/microsoft/typescript-go/internal/execute/tsc.go:263 +0x5e5
npm error github.com/microsoft/typescript-go/internal/execute.tscCompilation({0xe71e58, 0xc000088780}, 0xc000138b40, {0x0, 0x0})
npm error 	github.com/microsoft/typescript-go/internal/execute/tsc.go:200 +0xbef
npm error github.com/microsoft/typescript-go/internal/execute.CommandLine({0xe71e58, 0xc000088780}, {0xc0000a6030, 0x0, 0x0}, {0x0, 0x0})
npm error 	github.com/microsoft/typescript-go/internal/execute/tsc.go:34 +0x145
npm error main.runMain()
npm error 	github.com/microsoft/typescript-go/cmd/tsgo/main.go:23 +0x10c
npm error main.main()
npm error 	github.com/microsoft/typescript-go/cmd/tsgo/main.go:10 +0x13