added gating for user preferences for auto imports #1793
Conversation
…3/typescript-go into auto-imports-user-prefs" This reverts commit 865d44bc8948e7165defb117837464f5cbe2326d, reversing changes made to 186540b5240e2e31e61a2c4a8467d79b8174292c.
johnfav03
changed the title
johnfav03
changed the title
|
Is the test generator just missing these options such that all tests are new handwritten ones? |
Isabel mentioned that I'd need to handwrite tests using |
|
Codefixes were ported in #2053 |
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Seems good, just a few small things.
| return true | ||
| } | ||
| } | ||
| // !! SymlinkCache |
There was a problem hiding this comment.
The symlink cache should now be available.
There was a problem hiding this comment.
Don't bother changing anything in this file more than you need to
There was a problem hiding this comment.
alright, ignore me, I guess this is going away soon 😄
There was a problem hiding this comment.
Sounds good, should be ready for final review then
…refs' into auto-imports-user-prefs
3 participants
Implements and tests User Preferences for Auto Imports; the specific preferences included are shown below.
importModuleSpecifierPreference: "shortest" | "project-relative" | "relative" | "non-relative";importModuleSpecifierEnding: "auto" | "minimal" | "index" | "js";includePackageJsonAutoImports: "auto" | "on" | "off";allowRenameOfImportPath: boolean;autoImportFileExcludePatterns: string[];autoImportSpecifierExcludeRegexes: string[];preferTypeOnlyAutoImports: boolean;