Update clang-format to 9.0.0

[13rac1]

Type: General

Describe the bug
Extension installs clang-format 6.0.0, but 7.0.0 is available from: http://releases.llvm.org/download.html

• OS and Version: Ubuntu 18.04
• VS Code Version:

Version: 1.29.1
Commit: bc24f98b5f70467bc689abf41cc5550ca637088e
Date: 2018-11-15T19:07:43.495Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

• C/C++ Extension Version: ms-vscode.cpptools@0.20.1

To Reproduce

$ $HOME/.vscode/extensions/ms-vscode.cpptools-0.20.1/LLVM/bin/clang-format -version
clang-format version 6.0.0 (tags/RELEASE_600/final)

Download location is set here: https://github.com/Microsoft/vscode-cpptools/blob/8c53c027cab1f5b110367cb08ab8286a1a98ea80/Extension/package.json#L1483-L1527

Expected behavior

$ clang-format -version
clang-format version 7.0.0 (tags/RELEASE_700/final)

Thanks!

[sean-mcmanus]

Yeah, Visual Studio updated to clang-format 7 a while ago, but we were too busy and weren't sure if it had significant enough features bother with, i.e. I think this is the first user request we've had for that. Users who really need it can download it themselves and set the C_Cpp.clang_format_path. It looks like 7.0.1 is getting released next week so maybe we'll wait for that.

[xgalaxy]

The latest version of ClangFormat has a new IndentPPDirective option that I would very much love to have.

Just giving this ticket a little poke in the hopes that the included ClangFormat gets updated with the latest soon.

[sean-mcmanus]

@xgalaxy If you really want the newer clang-format you can download it and set the clang_format_path setting. It takes us longer to upgrade due to additional stuff we need to do (signing, test changes, publishing, etc.).

[ncihnegn]

The right thing to do is to pick the clang-format in PATH over the VSCode one.