Skip to content

Conversation

@sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus commented Nov 12, 2025

It was generated by Copilot but it took multiple tries to get correct.

@sean-mcmanus sean-mcmanus requested a review from a team as a code owner November 12, 2025 22:26
@github-project-automation github-project-automation bot moved this to Pull Request in cpptools Nov 12, 2025
@bobbrow
Copy link
Member

bobbrow commented Nov 12, 2025

Isn't there a retry property we can use? I thought we used that in our other pipelines.

@sean-mcmanus
Copy link
Contributor Author

Isn't there a retry property we can use? I thought we used that in our other pipelines.

Copilot is saying

The retryCountOnTaskFailure property is available for some tasks, but not for bash or script steps.

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Nov 12, 2025

Isn't there a retry property we can use? I thought we used that in our other pipelines.

Copilot is saying

The retryCountOnTaskFailure property is available for some tasks, but not for bash or script steps.

Oh, but I see it used in our other scripts? Maybe Copilot is wrong? Or could our existing scripts just be ignoring that retry?

UPDATE: I believe Copilot may have used the script because that allows a timed sleep between retries which the retryCountOnTaskFaiure doesn't do...however, I don't know if this failure case requires a sleep or not.

UPDATE: Next time when Copilot generates unexpected code, I should ask it why instead of just changing it since it might have a reason such as this case. I hit that issue before in another case too.

bobbrow
bobbrow previously approved these changes Nov 12, 2025
@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Nov 13, 2025

@bobbrow I switched by back to the script to allow a sleep between retries since otherwise I suspect it will just fail repeatedly like we hit in another case where we had to use a similar loop with a sleep.

UPDATE: Okay, I finally got it to work using retry on the task and a sleep in the script -- I hit a problem with the \ not working from the variable expansion in the bash script that I had to add a couple lines to fix.

@sean-mcmanus sean-mcmanus requested a review from bobbrow November 13, 2025 00:51
@sean-mcmanus sean-mcmanus merged commit cf5de9c into main Nov 13, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Nov 13, 2025
@sean-mcmanus sean-mcmanus deleted the seanmcm/addBuildFilesRetry branch November 13, 2025 16:49
sean-mcmanus added a commit that referenced this pull request Dec 2, 2025
* put standard library file associations in package.json (#14002)

* Fix incorrect comma in settings string. (#14005)

* Update IntelliSense strings (translations are available yet). (#14020)

* Enable setting the VS dev environment without running from Dev Command Prompt (#13571)

* For VS 18.0 and above, use "Insiders" instead of "Preview" (#14022)

* Adding telemetry for devcmd environment usage (#14023)

* Update changelog and version for 1.29.0. (#14028)

* Update changelog and version for 1.29.0.

* Update TPN. (#14029)

* Update changelog (2nd time). (#14032)

* Update IntelliSense loc strings. (#14038)

* Update localization (#14039)

* Localization - Translated Strings

* Some fixes.

* Remove \t.

---------

Co-authored-by: csigs <[email protected]>

* Update the msvc version to 1950. (#14042)

* Retry build files task in cg.yml (#14043)

* Retry build files.

* Update changelog for 1.29.1. (#14058)

* Bump js-yaml from 4.1.0 to 4.1.1 in /Extension (#14060)

Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.1.0...4.1.1)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.1.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update js-yaml for github actions. (#14061)

* Fix typo "no_suitable_complier" in nativeStrings.json (#14064)

* Update changelog and verison for 1.29.2. (#14070)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Bob Brown <[email protected]>
Co-authored-by: csigs <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dhruvil Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants