Skip to content

Conversation

@fsschneider
Copy link
Contributor

This PR replaces the current setup.cfg and setup.py with (hopefully) equivalent pyproject.toml.
As described in #803 this is the PEP standard for package setup.
It probably doesn't fully resolve said issue as it also included more proposed changes du the dataset setup.

Note: We plan to move to ruff (replacing isort, pylint and yapf) as well as renaming the package to algoperf. Therefore, the pyproject.toml will change substantially with follow-up PRs.

@IFFranciscoME, I currently can't add you as a reviewer, but I am happy to hear your feedback as well.

@fsschneider fsschneider requested a review from a team as a code owner January 15, 2025 12:12
@github-actions
Copy link

github-actions bot commented Jan 15, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@IFFranciscoME
Copy link

@fsschneider Thanks for the tag and the acknowledgement of the 2 cents of work I've previously added to this engineering topic.

From a quick look, here are some notes

  1. 100% agree in going for pyproject.toml, which I think is a good starter for a folder restructure as well.

  2. Great to see the [project.optional-dependencies]

  3. Perhaps "compiled examples" could be a good thing, i.e. to have an already compiled version of the package, for a "standard" system architecture-config.

I will try to make more free space for this, have had a lot of focus on some PhD work in the past 2 months, but hey, time in one's agenda is not to be founded but has to be created.

This was referenced Jan 15, 2025
@priyakasimbeg
Copy link
Contributor

Just checking, this doesn't require any updates to our documentation (instructions for installation) right?

@fsschneider
Copy link
Contributor Author

No, I don't think so. It is still pip installable as before and all commands are identical.

@priyakasimbeg priyakasimbeg merged commit c1f182e into mlcommons:dev Feb 5, 2025
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
@fsschneider fsschneider deleted the pyproject.toml branch June 18, 2025 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants