Adjust logging level for frequent / low-level events #130
+19
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
force-pushed
the
mattt/trace-logging
branch
from
e463798 to
5bcac84
Compare
There was a problem hiding this comment.
Pull Request Overview
Lower log level from debug to trace for frequent/low-level events across server, client, and transport layers.
- Replace
logger.debugcalls withlogger.tracefor batch, request/response, notification, heartbeat, and SSE events. - No functional changes; purely adjusts verbosity.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/MCP/Server/Server.swift | Lowered batch, request, and notification logs from debug to trace |
| Sources/MCP/Client/Client.swift | Changed response, notification, and batch response logs to trace |
| Sources/MCP/Base/Transports/StdioTransport.swift | Updated message reception logs from debug to trace |
| Sources/MCP/Base/Transports/NetworkTransport.swift | Adjusted heartbeat and connection logs from debug to trace |
| Sources/MCP/Base/Transports/HTTPClientTransport.swift | Swapped debug to trace for SSE, JSON, and session ID signaling logs |
Comments suppressed due to low confidence (1)
Sources/MCP/Base/Transports/HTTPClientTransport.swift:439
- Indentation for this
logger.tracecall is inconsistent with the surrounding block; align it with the other logging statements (16 spaces).
logger.trace(
mattt
force-pushed
the
mattt/trace-logging
branch
from
5bcac84 to
22ca0f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #129