Add waitUntilComplete() method to Server #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great idea, @adamwulf. Thank you for opening this PR. Left a question about the spelling, but I'm totally on board with this enhancement. |
Contributor
Author
|
I don't see a spelling feedback/question? |
mattt
reviewed
Mar 27, 2025
Contributor
|
@adamwulf 😓 d'oh. Sorry, I'd left that as Should be there now. |
Co-authored-by: Mattt <[email protected]>
Contributor
Author
|
ah - good catch, matching Metal is a good way to go |
devyhan
pushed a commit
to devyhan/swift-sdk
that referenced
this pull request
Apr 4, 2025
* Add waitUntilComplete() method to Server * Update Sources/MCP/Server/Server.swift Co-authored-by: Mattt <[email protected]> --------- Co-authored-by: Mattt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a small helper method to wait until the serve completes. This is handy when integrating the mcp server into a command line utility.