suppress some psalm reported errors #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementation or are related to deserialization workaround
drealecs
force-pushed
the
fix_psalm_reported_issues
branch
from
af073a6 to
c55aa7f
Compare
mnapoli
reviewed
Feb 27, 2021
Member
mnapoli
left a comment
mnapoli
left a comment
There was a problem hiding this comment.
Thanks for dealing with these issues!
Looks good to me, I added 2 questions inline.
| * | ||
| * @psalm-pure | ||
| * @psalm-assert T $value | ||
| * @param mixed $value |
Member
There was a problem hiding this comment.
Why add this parameter docblock?
Contributor
Author
There was a problem hiding this comment.
There is a MissingParamType psalm error.
https://psalm.dev/docs/running_psalm/issues/MissingParamType/
| * @psalm-pure | ||
| * @psalm-assert T $value | ||
| * @param mixed $value | ||
| * @return string |
Contributor
Author
There was a problem hiding this comment.
Same here. The @return I guess it's just the PhpStorm complaining about.
Contributor
Author
|
Just a mention here. This is not very important to be released after merge. The changes are mostly for fixing pipeline on master. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suppress some psalm errors that are actually bugs in current psalm implementation or are related to deserialization workaround