chore: remove error for no-unused-vars #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahetter
added
the
type: chore
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
no-unused-varseslint rule causes issues with Typescript, such as flagging an issue withflowArgsbelow being "unused".I checked in our next&gatsby plugins, and the gatsby plugin does not explicitly say to error as we were doing here (
no-unused-varsis not mentioned at all in .eslintrc), and the next plugin explicitly turns off this rule ('no-unused-vars': 0), so I have removed this one as well.I've created a draft issue in our board for us to think about getting all of our repos aligned in regards to the .eslintrc.js files.