-
Notifications
You must be signed in to change notification settings - Fork 102
Fix isAllowedDir matching by prefix #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerugbo
approved these changes
Sep 16, 2025
UnwashedMeme
requested changes
Sep 16, 2025
UnwashedMeme
approved these changes
Sep 24, 2025
aphralG
reviewed
Sep 25, 2025
dhurley
approved these changes
Sep 25, 2025
craigell
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Stops isAllowedDir function from matching by prefix. Originally this function would allow any path which was prefixed by an allowed directory, i.e
/var/log/nginxwas present in allowed dirs, then the path/var/log/nginx-testwould also be allowed. Not good!This PR stops this match from taking place, but still matches if the provided path is a subdirectory of an already allowed directory, i.e
/var/log/nginxis in allowed dirs,/var/log/nginx/mysubdirwill be allowed but/var/log/nginx-testwill be blocked.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)