Skip to content

jenkins: fix arm64 debug build compiler selection #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
targos merged 1 commit into from
Sep 21, 2023
Merged

jenkins: fix arm64 debug build compiler selection #3493

targos merged 1 commit into from
Sep 21, 2023

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Sep 20, 2023

Debug builds are not suffixed with _sharedlibs so were not matching the intended case selection.

Refs: #3485 (comment)

cc @targos

@richardlau
jenkins: fix arm64 debug build compiler selection
23077af 
Debug builds are not suffixed with `_sharedlibs` so were not matching
the intended case selection.
richardlau
richardlau commented Sep 20, 2023
View reviewed changes
@richardlau richardlau mentioned this pull request Sep 20, 2023
Merged
@targos targos merged commit 896e834 into nodejs:main Sep 21, 2023
@targos
Copy link
Member

targos commented Sep 21, 2023

Rebuild of the test job: https://ci.nodejs.org/job/node-test-commit-arm-debug/9410/

@targos
Copy link
Member

targos commented Sep 21, 2023 

11:14:14 Node.js configure: Found Python 3.8.10...
11:14:14 Detected C++ compiler (CXX=ccache g++-10) version: 10.5.0
11:14:14 Detected C compiler (CC=ccache gcc-10) version: 10.5.0

🎉

@richardlau richardlau deleted the ubuntu2004-gcc10 branch September 21, 2023 12:16
@richardlau richardlau mentioned this pull request Sep 21, 2023
Merged
3 tasks
richardlau added a commit that referenced this pull request Sep 21, 2023
@richardlau
ansible: install gcc-10 in remaining Ubuntu 20.04 containers (#3495)
660f914 
Refs: #3493 (comment)
Refs: #3485 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@MoLow MoLow MoLow approved these changes

Assignees

No one assigned

Labels

jenkins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@richardlau @targos @MoLow