-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Closed
Labels
flaky-testIssues and PRs related to the tests with unstable failures on the CI.Issues and PRs related to the tests with unstable failures on the CI.performanceIssues and PRs related to the performance of Node.js.Issues and PRs related to the performance of Node.js.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Description
https://ci.nodejs.org/job/node-test-binary-arm/3710/RUN_SUBSET=4,label=pi1-docker/console
00:40:41 not ok 330 sequential/test-performance
00:40:41 ---
00:40:41 duration_ms: 5.141
00:40:41 severity: fail
00:40:41 exitcode: 1
00:40:41 stack: |-
00:40:41 { name: 'node',
00:40:41 entryType: 'node',
00:40:41 startTime: 0,
00:40:41 duration: { around: 4609.206676006317 },
00:40:41 nodeStart: { around: 0 },
00:40:41 v8Start: { around: 0 },
00:40:41 bootstrapComplete: { around: 4517.247398018837 },
00:40:41 environment: { around: 0 },
00:40:41 loopStart: -1,
00:40:41 loopExit: -1 }
00:40:41 assert.js:349
00:40:41 throw err;
00:40:41 ^
00:40:41
00:40:41 AssertionError [ERR_ASSERTION]: bootstrapComplete: 1233.9948890209198 >= 1111
00:40:41 at checkNodeTiming (/home/iojs/build/workspace/node-test-binary-arm/test/sequential/test-performance.js:92:7)
00:40:41 at Object.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/sequential/test-performance.js:104:1)
00:40:41 at Module._compile (internal/modules/cjs/loader.js:703:30)
00:40:41 at Object.Module._extensions..js (internal/modules/cjs/loader.js:714:10)
00:40:41 at Module.load (internal/modules/cjs/loader.js:613:32)
00:40:41 at tryModuleLoad (internal/modules/cjs/loader.js:552:12)
00:40:41 at Function.Module._load (internal/modules/cjs/loader.js:544:3)
00:40:41 at Function.Module.runMain (internal/modules/cjs/loader.js:756:12)
00:40:41 at startup (internal/bootstrap/node.js:303:19)
00:40:41 at bootstrapNodeJSCore (internal/bootstrap/node.js:865:3)
00:40:41 ...Looks like a case of testing elapsed time (as a proxy for performance?). Is this a case of the test being unreliable or is it a case of the test flagging something we care about? Test doesn't have a comment explaining itself but it was added in 67269fd / #14680 and there's context there.
/ping @jasnell
Metadata
Metadata
Assignees
Labels
flaky-testIssues and PRs related to the tests with unstable failures on the CI.Issues and PRs related to the tests with unstable failures on the CI.performanceIssues and PRs related to the performance of Node.js.Issues and PRs related to the performance of Node.js.testIssues and PRs related to the tests.Issues and PRs related to the tests.